harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Morozova, Nadezhda" <nadezhda.moroz...@intel.com>
Subject RE: [doc] Why do we have boxes drawn around source now?
Date Fri, 22 Sep 2006 12:49:09 GMT
Looks ok. I don't think I need to verify - you're more experienced with
vsl anyway :) I'll let you know if I find an occurrence where it does
not behave as we expect it.

Best regards, 
Nadya Morozova
 

-----Original Message-----
From: Geir Magnusson Jr. [mailto:geir@pobox.com] 
Sent: Friday, September 22, 2006 4:47 PM
To: harmony-dev@incubator.apache.org
Subject: Re: [doc] Why do we have boxes drawn around source now? 

I think it looks good.  I just took out all the table junk so we have

#macro ( source $value)
     <div>
<pre>$escape.getText($value.getText())</pre>
     </div>
#end


Do you want to verify before I check it in?

geir



On Sep 22, 2006, at 8:43 AM, Geir Magnusson Jr. wrote:

>
> On Sep 22, 2006, at 8:34 AM, Morozova, Nadezhda wrote:
>
>> Geir,
>>
>> I know where the outer box comes from - site.vsl, special handling of
>> <source> snippets. Can send you a quick patch to remove the outer  
>> box.
>
> I'm looking at that now and have removed it.  'm just scanning the  
> site now to see what breaks when we do that...
>
> geir
>
>>
>> Best regards,
>> Nadya Morozova
>>
>>
>> -----Original Message-----
>> From: Geir Magnusson Jr. [mailto:geir@pobox.com]
>> Sent: Friday, September 22, 2006 4:25 PM
>> To: harmony-dev@incubator.apache.org
>> Subject: Re: [doc] Why do we have boxes drawn around source now?
>>
>>
>> On Sep 22, 2006, at 4:04 AM, Mark Hindess wrote:
>>
>>>
>>> On 21 September 2006 at 23:15, "Geir Magnusson Jr."
>>> <geir@pobox.com> wrote:
>>>>
>>>> On Sep 21, 2006, at 10:06 PM, Richard Liang wrote:
>>>>
>>>>> On 9/22/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>>>>>> Is this new?  We now have boxes drawn around the shaded box on a
>>>>>> <source> document snippet...
>>>>>>
>>>>>
>>>>> Maybe because we now have unified site.css (HARMONY-1384[1]) to  
>>>>> make
>>>>> our pages more beautiful ;-)
>>>>
>>>> I know how they are getting there.  I don't know why...  they gotta
>>>> go...
>>>
>>> Why?  Because I guess Nadya thought they helped improve the  
>>> clarity of
>>> some pages.  (I did too so was happy to commit that change.)
>>>
>>> I didn't check every page so perhaps on some it looks bad?
>>
>> Well, there are two boxes.  There is a nice pink box that contains
>> the code, and then there is a box drawn around that on the outside...
>>
>> I like the inner box.  Looks nice and neat.  Outer box?  Not so  
>> much :)
>>
>> geir
>>
>>>
>>> -Mark.
>>>
>>>> geir
>>>>
>>>>> [1] http://issues.apache.org/jira/browse/HARMONY-1384
>>>>>
>>>>> Best regards,
>>>>> Richard
>>>>>
>>>>>> geir
>>>>>>
>>>>>> -----------------------------------------------------------------

>>>>>> --
>>
>>>>>> --
>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>> To unsubscribe, e-mail: harmony-dev-
>>>>>> unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail: harmony-dev-
>>>>>> help@incubator.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> -- 
>>>>> Richard Liang
>>>>> China Development Lab, IBM
>>>>>
>>>>> ------------------------------------------------------------------

>>>>> --
>>
>>>>> -
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev- 
>>>>> unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-
>>>>> help@incubator.apache.org
>>>>>
>>>>
>>>>
>>>> -------------------------------------------------------------------

>>>> --
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev- 
>>>> unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-
>>>> help@incubator.apache.org
>>>>
>>>
>>>
>>>
>>> --------------------------------------------------------------------

>>> -
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev- 
>>> help@incubator.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev- 
>> help@incubator.apache.org
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev- 
>> help@incubator.apache.org
>>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message