harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang" <zhanghuang...@gmail.com>
Subject Re: [testing][beans] reverse engineering of RI
Date Fri, 15 Sep 2006 13:17:04 GMT
On 9/15/06, Alexei Zakharov <alexei.zakharov@gmail.com> wrote:
>
> Hi all,
>
> While investigating one of the failed tests from the beans module
> (PersistenceDelegateTest#*) I have discovered that the test is doing a
> reverse engineering in fact. It passes some worm-like object to public
> API method and then analyzes the calling stacktrace of each of its
> methods by means of
>
> StackTraceElement[] eles = (new Throwable()).getStackTrace();
> if (eles[i].getClassName().equals(…) &&
> eles[i].getMethodName().equals(..)) {…}


OMG! what's the intention of such assertion?


In that way, to enable this test we need to rewrite our code and make
> it identical to RI's (at least in respect to the stack trace). Such
> testing technique may be applied to many parts of Java API, not only
> beans. Of course I can imagine some user application doing this but
> such people should probably know what they do.
>
> Personally I don't like such methods of testing and vote for
> refactoring of these tests. Other opinions? Thoughts?


 I strongly agree to refactor these tests!

Thanks,
>
> --
> Alexei Zakharov,
> Intel Middleware Product Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Andrew Zhang
China Software Development Lab, IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message