harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Spark Shen <smallsmallor...@gmail.com>
Subject Re: [classlib][test]Deal with un-deleted temp files created in tests
Date Thu, 28 Sep 2006 06:23:05 GMT
Jimmy, Jing Lv 写道:
> Hi,
>
> Recently I find some temp files created in tests are not deleted. We 
> may delete them, or put them in test/resource .
> 1)in module\archive:
> modules\archive\GZIPOutFinish.txt
> modules\archive\GZIPOutClose2.txt
> modules\archive\GZIPOutWrite.txt
> modules\archive\JDK2-3gabba.zip
> Take a close look into it, the first three files are created in 
> GZIPOutputStreamTest. Seems the files were deleted in tearDown(), but 
> very strangely the lines of deleting files was comment-out without any 
> comment. Do anyone know why? If I delete these files, no error was 
> occurred in test on winxp.
> And the last file was created ZipFileTest, which has a comment that 
> "Note zfile is a user-defined zip file used by other tests and should 
> not be deleted", it seems it must be put in resource directory. 
> However,if I do delete it in tearDown(), no error was occurred while 
> run archive test on winxp.
> 2)in luni:
> modules\luni\hyts_missingclass.ser
> This file is created in ObjectInputStreamTest. The test try to test 
> serialization, however it did not follow our serialization-test 
> framework. The fix is easy (change it to use the framework).
> 3)in jndi:
> a new directory "org\apache\harmony\jndi\tests\javax\naming\spi" with 
> a file "jndiprovider.properties" and a sub directory "mock".
> This directory is created in NamingManagerTest, I guess it must be put 
> in some place in test\resource ?
>
> Any suggestions/comments? And any more such files to deal? Thanks!
Put them in places where are appropriate according to various guide lines.

Best regards

-- 
Spark Shen
China Software Development Lab, IBM


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message