harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [classlib][testing] give DRLVM a chance!
Date Thu, 14 Sep 2006 15:12:58 GMT
Ah - yes - lets not call it "sun" then if it's universal.


Mikhail Loenko wrote:
> 2006/9/14, Geir Magnusson Jr. <geir@pobox.com>:
>> I don't understand either.
> 
> Neither do I :)
> 
> It's not clear for me why different command lines are generated for Sun 
> and IBM,
> given that the tests pass on IBM if Sun's command line is passed there
> 
> What I suggest is to start all VMs with the same options.
> 
> Thanks
> Mikhail
> 
>>
>> (And we'd certainly want to always be able to choose J9 or whatever else
>> shows up too...)
>>
>> geir
>>
>>
>> Oliver Deakin wrote:
>> > Does this mean we could no longer use the IBM VME to run the tests?
>> >
>> > Regards,
>> > Oliver
>> >
>> > Mikhail Loenko wrote:
>> >> There are two options supported by Support_Exec: IBM and Sun
>> >>
>> >> I'd like to apply this change (remove "IBM" branch and leave the Sun
>> >> branch for
>> >> all VMs):
>> >>
>> >>
>> >> Index:
>> >> 
>> C:/WS/Experiments/support/src/test/java/tests/support/Support_Exec.java
>> >> ===================================================================
>> >> ---
>> >> 
>> C:/WS/Experiments/support/src/test/java/tests/support/Support_Exec.java
>> >> (revision
>> >> 442625)
>> >> +++
>> >> 
>> C:/WS/Experiments/support/src/test/java/tests/support/Support_Exec.java
>> >> (working
>> >> copy)
>> >> @@ -68,7 +68,7 @@
>> >>         if (classpath != null)
>> >>             for (int i = 0; i < classpath.length; i++)
>> >>                 classPathString += File.pathSeparator + classpath[i];
>> >> -        if (vendor.indexOf("Sun") != -1) {
>> >> +
>> >>             baseArgs = 3;
>> >>             execArgs = new String[baseArgs + args.length];
>> >>             String executable = System.getProperty("java.home");
>> >> @@ -79,35 +79,6 @@
>> >>             execArgs[1] = "-cp";
>> >>             execArgs[2] = "\"" + System.getProperty("java.class.path")
>> >>                     + classPathString + "\"";
>> >> -        } else if (vendor.indexOf("IBM") != -1) {
>> >> -            baseArgs = 5;
>> >> -            String full = System.getProperty("java.fullversion");
>> >> -            if (full != null && full.indexOf("(JIT disabled") >=
0)
>> >> -                baseArgs++;
>> >> -            execArgs = new String[baseArgs + args.length];
>> >> -            execArgs[0] = System.getProperty("com.ibm.oti.vm.exe");
>> >> -            // stop passing -jcl:null into the VM
>> >> -            // WARNING: empty string in args array may confuse
>> >> -            // Process.exec(String[] cmdarray) on Linux so
>> >> -            // Process.exec(String command) is used instead
>> >> -            execArgs[1] = "";
>> >> -            if (onUnix) {
>> >> -                execArgs[2] = "-Xbootclasspath:"
>> >> -                        +
>> >> System.getProperty("org.apache.harmony.boot.class.path");
>> >> -                execArgs[3] = "-cp";
>> >> -                execArgs[4] = System.getProperty("java.class.path")
>> >> -                        + classPathString;
>> >> -            } else {
>> >> -                execArgs[2] = "\"-Xbootclasspath:"
>> >> -                        +
>> >> System.getProperty("org.apache.harmony.boot.class.path")
>> >> -                        + "\"";
>> >> -                execArgs[3] = "-cp";
>> >> -                execArgs[4] = "\"" +
>> >> System.getProperty("java.class.path")
>> >> -                        + classPathString + "\"";
>> >> -            }
>> >> -            if (baseArgs > 5)
>> >> -                execArgs[5] = "-Xint";
>> >> -        }
>> >>         for (int i = 0; i < args.length; i++)
>> >>             execArgs[baseArgs + i] = args[i];
>> >>         StringBuffer command = new StringBuffer(execArgs[0]);
>> >>
>> >>
>> >>
>> >> Tests pass on WinXP and Linux. Objections?
>> >>
>> >> Thanks,
>> >> Mikhail
>> >>
>> >> ---------------------------------------------------------------------
>> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message