harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [classlib][luni] Put setInterruptAction() in our j.l.Thread stub?
Date Thu, 14 Sep 2006 14:47:18 GMT
So - no matter what happens w/ the docs, we do need this in the code...

geir


Tim Ellison wrote:
> yep -- that's what I meant.  The on-line doc should be generated from
> the code comments as it is today.
> 
> Regards,
> Tim
> 
> Morozova, Nadezhda wrote:
>> As I got it, the referenced documentation is created from code already,
>> so I don't quite get Geir's comment ;( 
>> Anyway, I agree that keeping docs up-to-date is important. Do you think
>> we can ask the community to update comments with the code changes? This
>> way, the docs will never be out-of-sync. And those reading the code will
>> have a better understanding of what it does.
>>
>> Best regards, 
>> Nadya Morozova
>>  
>>
>> -----Original Message-----
>> From: Geir Magnusson Jr. [mailto:geir@pobox.com] 
>> Sent: Thursday, September 14, 2006 5:36 PM
>> To: harmony-dev@incubator.apache.org
>> Subject: Re: [classlib][luni] Put setInterruptAction() in our j.l.Thread
>> stub?
>>
>> true, but there's no reason why this couldn't be in the code too...
>>
>> geir
>>
>> Tim Ellison wrote:
>>> Our VM interface documentation[1] is drifting out of sync with code
>>> changes.  If anyone has time to refresh it, with help from the dev
>> list,
>>> that would be a very valuable task.  We should ensure that VM writers
>>> understand how to get the harmony class library code working with
>> their VM.
>>> [1] amongst others,
>>>
>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/d
>> oc/kernel_doc/html/index.html?view=co
>>> Regards,
>>> Tim
>>>
>>>
>>> Oliver Deakin wrote:
>>>> Geir Magnusson Jr. wrote:
>>>>> This came up in another thread.
>>>>>
>>>>> Currently, java.nio.channels.spi.AbstractInterruptibleChannel
>> depends
>>>>> on there being a setInterruptAction() method on java.lang.Thread.
>>>>>
>>>>> I certainly think that this kind of thing should be documented, so
>> the
>>>>> question - should we add this to our Thread stub class?
>>>> Yes we should - I didn't realise initially that this method was being
>>>> used (since it was private).
>>>> Now we know it's in use in AbstractInterruptibleChannel, we'd better
>> put
>>>> some doc in for future
>>>> kernel writers. Can someone just bring back the original comments and
>>>> method stub that was
>>>> there?
>>>>
>>>> Regards,
>>>> Oliver
>>>>
>>>>> geir
>>>>>
>>>>>
>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail:
>> harmony-dev-help@incubator.apache.org
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message