harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [drlvm] HARMONY-1364 - question about init_stack_info()
Date Sat, 09 Sep 2006 01:14:09 GMT
Ok - sounds good. I assume putting in a TODO in the code reminding 
ourselves would be reasonable?

geir

Rana Dasgupta wrote:
> Geir,
>  Good question. The init_stack_info() is really a misnomer. It is an
> initialization needed for the overflow exception handling machinery only.
> That does not mean that it could not be initialized in a single location
> eg., when the vm thread is attached, but it is a somewhat more local
> initialization. In fact, it was being being initialized somewhere here
> before, but I think that it got overwritten in a recent commit.
>  I think that this change is better seen a temporary fix in the SOE
> machinery, which needs a lot more changes. For example, to prevent failures
> in creation of the exception object during suspend_disable(), we will 
> likely
> pre-create the exception object at init. If so, this type of initialization
> would probably move there. But we haven't yet agreed on some of this
> pre-creation at initialization etc. stuff (on a different thread ), whether
> we want to handle lazily, etc. So, this is sort of an interim fix to stop
> the asserts until we agree on some broader aspects of overflow exception
> handling.
> 
> Thanks,
> Rana
> 
> 
> 
> On 9/8/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>>
>>
>> Rana,
>>
>> in the patch included w/ Harmony-1364, you are calling init_stack_info()
>> in two different files (one for Windows, one for linux), you are testing
>> to see if you need to call init_stack_info(), and then calling if so.
>>
>> Do you expect that someone else should have caleld init_stack_info(),
>> and if so, why not go after the root cause and ensure that it's setup
>> correctly all the time...
>>
>> geir
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message