harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [classlib][luni] signalis interruptus in hysock
Date Thu, 07 Sep 2006 18:10:57 GMT
And one other comment on the proposed patch...  it doesn't respect the 
timeout as it restarts the select() with the original timeout...



Geir Magnusson Jr. wrote:
> 
> 
> Weldon Washburn wrote:
>> On 9/1/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>>>
>>>
>>>
>>> Artem Aliev wrote:
>>> > The hyport and hy* are a porting layer that provides os independent
>>> > interface.
>>> > hysock_select() does not return EINTR on windows why it should do it
>>> > under linux?
>>> > either user presses Ctrl-c or ctrl-\ or VM uses other signals for its
>>> > owns needs.
>>>
>>> I think you just gave me the answer.
>>>
>>> The *caller* to hysock_select() needs to decide what to do on EINTR, not
>>> hysock_select() itself.
>>>
>>> I still don't think this is a perfect solution, but I think it's 
>>> better :)
>>
>>
>> Does the above solve the problem completely or is it a temporary patch?
> 
> I don't know, but happy to call it a temporary patch - right now we're 
> stuck, because we can't even run tomcat and I want to do a new snapshot.
> 
>> Will the caller to hysock_select() need to have "#ifdef Windows.... 
>> #ifdef
>> Linux..."?
> 
> We already have platform specific code that calls hysock_select()
> 
> geir
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message