harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Deakin <oliver.dea...@googlemail.com>
Subject Re: [build] Use Sun 5.0_8 or Eclipse Compiler for automated builds
Date Thu, 07 Sep 2006 09:31:46 GMT
Alexey Varlamov wrote:
> 2006/9/7, Oliver Deakin <oliver.deakin@googlemail.com>:
>>
>>
>> Nathan Beyer wrote:
>> >
>> >> -----Original Message-----
>> >> From: Richard Liang [mailto:richard.liangyx@gmail.com]
>> >>
>> >>  Sun compiler (5.0_8) also has some unexpected behavior. See[1]
>> >>
>> >> [1]http://mail-archives.apache.org/mod_mbox/incubator-harmony-
>> >> dev/200608.mbox/%3c44F2DADE.5060900@gmail.com%3e
>> >>
>> >>
>> >
>> > I've found that a second or third "ant build" takes care of it. 
>> What I've
>> > noticed though is that the failures are all linking to elements 
>> from classes
>> > in luni-kernel. I'm looking at it, but I think there are some 
>> issues with
>> > what's put on the bootclasspath. I've already found one discrepancy 
>> between
>> > some of our 'luni-kernel' stubs and the spec. The Method.invoke() 
>> uses a
>> > vararg and our stub didn't have this.
>> >
>>
>> I spotted this as well, was preparing a patch for it - unless you want
>> to just go ahead and
>> fix it?
>
> Could you please restore j.l.Thread.setInterruptAction() & co, as well?

Isn't setInterruptAction() a private method? Why do we need this in the 
luni-kernel
stubs?

As far as I can see, that is the only method that has been removed 
recently from the
Thread class stub - were there any others that I have missed that are 
required?

Regards,
Oliver

>
> -- 
> Alexey
>
>>
>> Regards,
>> Oliver
>>
>> > -Nathan
>> >
>> >
>> >
>> >>> There are a number of places that use ReferenceQueues and 
>> Reference, but
>> >>> can't be generified because of a bug in the Sun compilers prior to
>> >>>
>> >> 5.0_8. At
>> >>
>> >>> the end of this email is an example of code that causes a 
>> compiler error
>> >>>
>> >> in
>> >>
>> >>> previous releases. This issue does not affect the Eclipse 
>> compiler. I've
>> >>>
>> >> run
>> >>
>> >>> a full rebuild as of revision 440796 and everything compiles fine 
>> with
>> >>>
>> >> both
>> >>
>> >>> the Eclipse compiler and Sun 5.0_8 compiler.
>> >>>
>> >>>
>> >>>
>> >>> -Nathan
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>     private static final ReferenceQueue<Object> cacheQueue = new
>> >>> ReferenceQueue<Object>();
>> >>>
>> >>>
>> >>>
>> >>>     private static final class CacheEntry extends 
>> WeakReference<Object>
>> >>>
>> >> {
>> >>
>> >>>         String key;
>> >>>
>> >>>
>> >>>
>> >>>         CacheEntry(Object jar, String key, ReferenceQueue<Object>

>> queue)
>> >>>
>> >> {
>> >>
>> >>>             super(jar, queue);
>> >>>
>> >>>             this.key = key;
>> >>>
>> >>>         }
>> >>>
>> >>>     }
>> >>>
>> >>>
>> >>>
>> >>>     // ... code using the queue
>> >>>
>> >>>
>> >>>
>> >>>             CacheEntry entry;
>> >>>
>> >>>             // This cast fails on Sun 5.0_7 and prior compilers
>> >>>
>> >>>             while ((entry = (CacheEntry)cacheQueue.poll()) != 
>> null) {
>> >>>
>> >>>                 jarCache.remove(entry.key);
>> >>>
>> >>>             }
>> >>>
>> >>>
>> >>>
>> >>>     // . more code
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >> --
>> >> Richard Liang
>> >> China Software Development Lab, IBM
>> >>
>> >> ---------------------------------------------------------------------
>> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> >> For additional commands, e-mail: 
>> harmony-dev-help@incubator.apache.org
>> >>
>> >
>> >
>> > ---------------------------------------------------------------------
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>> >
>> >
>> >
>>
>> -- 
>> Oliver Deakin
>> IBM United Kingdom Limited
>>
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

-- 
Oliver Deakin
IBM United Kingdom Limited


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message