harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Wu" <wuyue...@gmail.com>
Subject Re: [classlib][i18n] Messages code comments
Date Mon, 11 Sep 2006 08:17:56 GMT
+1 to condense them into getString(String, Ojbect) by autoboxing.
And the getString(String,Object,Object) method can work with primitive
arguments also.

On 9/11/06, Nathan Beyer <nbeyer@kc.rr.com> wrote:
> Is there any reason that there are three overloaded getString(String, XXX)
> methods that take variations of Object?
>
>
>
> Can't we just condense this into one method?
>
>
>
> public static String getString(String key, Object. args)
>
>
>
> In fact, this signature allows for the getString(String) method to be
> removed as well, since a vararg argument can be omitted altogether.
> Additionally, I would change the format method to use a vararg as well.
>
>
>
> Also, I'd argue that there's little value in having the overloaded methods
> that take an 'int' and a 'char'. I'd suggest just letting autoboxing handle
> this in conjunction with the varargs.
>
>
>
> Where is the code generator for these classes located?
>
>
>
> -Nathan
>
>
>


-- 
Tony Wu
China Software Development Lab, IBM

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message