harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregory Shimansky <gshiman...@gmail.com>
Subject Re: [drlvm] Jars work again, and other notes
Date Mon, 18 Sep 2006 21:24:31 GMT
On Monday 18 September 2006 20:29 Geir Magnusson Jr. wrote:
> I'm at a conference today, but in my idle bits of time, I restored the
> capability to do
>
>     java -jar foo.jar
>
> I added a little JarRunner class to our kernel classes, but we should
> move this to classlib, as there's nothing DRLVM specific about it.  I
> also had to modify the launcher to get this to work, as there's a
> codepath in the launcher that makes DRLVM crash hard.  I've commented it
> out because it was just a safety check, but it would be good for us to
> figure out what it is.  Broken windows, and all that.
>
> One thing I noticed is that we now have to set JAVA_HOME correctly.  We
> never had to do this before, and from the stacktraces generated, I
> haven't a clue why.  Something for someone to figure out.
>
> Anyway, I'm going to test a bit more and then do a new set of snapshots.

There is a compilation warning (treated as error) for the launcher on windows. 
I think it doesn't deserve as JIRA since it is trivial to fix:

     [exec] ..\shared\main.c(628) : error C2220: warning treated as error - no 
object file generated
     [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner' : unreferenced 
local variable

With the following patch it works ok:

Index: modules/luni/src/main/native/launcher/shared/main.c
===================================================================
--- modules/luni/src/main/native/launcher/shared/main.c (revision 447550)
+++ modules/luni/src/main/native/launcher/shared/main.c (working copy)
@@ -625,7 +625,6 @@
     {
       if (isStandaloneJar)
         {
-          jclass jarRunner;
           jclass clazz;
           jmethodID mID;
           jstring jStrObject;

-- 
Gregory Shimansky, Intel Middleware Products Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message