harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [drlvm] my latest round of patches broke something
Date Tue, 26 Sep 2006 05:41:10 GMT

On Sep 25, 2006, at 5:07 PM, Rana Dasgupta wrote:

> Hi Weldon/Geir,
>   Looks like we have quite a few Windows failures. Could one of you  
> folks
> please add in the the new file:
>
> patches/win/APR/threadproc/win32/thread.c
>
>  that is in 1457, but possibly got dropped from the commit?

Possibly?  Most definitely!  So sorry.  I was a bonehead.

>
>  We also need H-1340 to fix the assert in the fat monitor.

Done

> H-1519 may be
> needed ( I suspect it is ), but we can look at it after the first  
> two fixes
> have gone in?

Look away

>
> Thanks,
> Rana
>
> On 9/25/06, Vladimir Gorr <vvgorr@gmail.com> wrote:
>>
>> On 9/25/06, Ilya Berezhniuk < ilya.berezhniuk@gmail.com> wrote:
>> >
>> > Geir, Vladimir,
>> >
>> > I've returned from vacation today, so my 2 cents to this  
>> discussion...
>> >
>> > I guess the problem have appeared because in r449399 the changes  
>> for
>> > win/apr_thread_ext.c
>> > were committed, but new file patches/win/APR/threadproc/win32/ 
>> thread.c
>> was
>> > not committed. These changes are work together.
>> >
>> > The patch suggested by Vladimir will not fix issue completely.
>>
>>
>> Maybe you are right. However I'd advise not to ignore our changes.
>> In our opinion they are also useful. I see this patch eliminates a  
>> lot of
>> test failures
>> we have now on Windows. BTW Rana mentions about this as well.
>>
>> Thanks,
>> Vladimir.
>>
>> I cannot provide a test for issue I have fixed (I can't understand  
>> how to
>> > create it),
>> > but it's quite enough to uncomment debug printing in
>> > apr_thread_yield_other()
>> > function to view differences on any simple Java application.
>> >
>> > 2006/9/25, Vladimir Gorr <vvgorr@gmail.com >:
>> > >
>> > > On 9/25/06, Geir Magnusson Jr. < geir@pobox.com> wrote:
>> > > >
>> > > >
>> > > > On Sep 25, 2006, at 5:19 AM, Vladimir Gorr wrote:
>> > > >
>> > > > > As for me (and other people) a lot of tests fail for the  
>> latest
>> > > > > sources (revision 449592).
>> > > > > I've run the build.bat clean; build.bat update; build.bat  
>> command
>> > > > > in compliance with comments for H-1457.
>> > > > > It's very strange for me it mentions here all C-unit tests  
>> work
>> > > > > fine. Sorry I cannot confirm this.
>> > > >
>> > > > It certainly did on my machine after a clean - update build,  
>> and
>> then
>> > > > hung on gc.LOS.
>> > >
>> > >
>> > > Under what platform? This problem exists only for Windows.
>> > >
>> > > Thanks,
>> > > Vladimir.
>> > >
>> > > > The detailed investigation showed the patch for H-1457 is
>> > > > > incorrect. I've attached a patch fixing this issue.
>> > > > > Thanks Evgueni Brevnov for preparing this patch. After  
>> applying
>> > > > > these changes the issue disappeared.
>> > > >
>> > > > Where is that patch?  it didn't make it through to list -  
>> can you
>> > > > just re-open 1457 and attach there?
>> > > >
>> > > > >
>> > > > > Geir, could you please look at this patch and apply it if  
>> there
>> are
>> > > > > no objections?
>> > > > >
>> > > > > Thanks in advance,
>> > > > > Vladimir.
>> > > > >
>> > > > > On 9/24/06, Geir Magnusson Jr. < geir@pobox.com> wrote:
 
>> Ok, I'm
>> not
>> > > > > as worried - I went back a few days to r447025 and still
>> > > > > have the problem, so it's not from this morning.  I guess  
>> this has
>> > > > > been masked all along by the logger problem.  Noted in JIRA
>> > > > > HARMONY-1560
>> > > > >
>> > > > > geir
>> > > > >
>> > > > > On Sep 23, 2006, at 11:04 AM, Geir Magnusson Jr. wrote:
>> > > > >
>> > > > > > This is completely my fault.
>> > > > > >
>> > > > > > The latest round of patches, while I dutifully do smoke,
 
>> c-unit
>> > and
>> > > > > > kernel tests for each patch, I didn't do any app testing.
>> > > > > >
>> > > > > > I tried to run ActiveMQ, and it breaks with an asset in
>> > > > > > object_handles.cpp : 99
>> > > > > >
>> > > > > > I'm going to back out the two GC patches I applied and 

>> hope for
>> > the
>> > > > > > best.
>> > > > > >
>> > > > > > geir
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > >
>> >  
>> ---------------------------------------------------------------------
>> > > > > > Terms of use : http://incubator.apache.org/harmony/ 
>> mailing.html
>> > > > > > To unsubscribe, e-mail:
>> > harmony-dev-unsubscribe@incubator.apache.org
>> > > > > > For additional commands, e-mail: harmony-dev-
>> > > > > help@incubator.apache.org
>> > > > > >
>> > > > >
>> > > > >
>> > > > >
>> >  
>> ---------------------------------------------------------------------
>> > > > > Terms of use : http://incubator.apache.org/harmony/ 
>> mailing.html
>> > > > > To unsubscribe, e-mail:
>> harmony-dev-unsubscribe@incubator.apache.org
>> > > > > For additional commands, e-mail:
>> > harmony-dev-help@incubator.apache.org
>> > > > >
>> > > > >
>> > > > >
>> >  
>> ---------------------------------------------------------------------
>> > > > > Terms of use : http://incubator.apache.org/harmony/ 
>> mailing.html
>> > > > > To unsubscribe, e-mail:
>> harmony-dev-unsubscribe@incubator.apache.org
>> > > > > For additional commands, e-mail:
>> > harmony-dev-help@incubator.apache.org
>> > > >
>> > > >
>> > > >
>> ---------------------------------------------------------------------
>> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > > > To unsubscribe, e-mail: harmony-dev- 
>> unsubscribe@incubator.apache.org
>> > > > For additional commands, e-mail:
>> harmony-dev-help@incubator.apache.org
>> > > >
>> > > >
>> > >
>> > >
>> >
>> >
>>
>>


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message