harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <nbe...@kc.rr.com>
Subject RE: [jira] Is it comfortable for committers when source and test patches are packed in the single diff file?
Date Wed, 27 Sep 2006 05:28:20 GMT

> -----Original Message-----
> From: Tim Ellison [mailto:t.p.ellison@gmail.com]
> 
> Geir Magnusson Jr. wrote:
> >
> > On Sep 26, 2006, at 10:23 AM, Denis Kishenko wrote:
> >
> >> Geir, thanks for answer.
> >>
> >> As I understand committers don't run tests from issue's descriptions?
> >
> > Sometimes.  But if a test can be provided, it makes things a lot easier
> > on the committers, and improves chances of getting in.
> 
> I agree -- and two patch files is just fine.
> 
> Regards,
> Tim

I'll add another vote to two patch files. I do exactly what Geir said; apply
the test patch, run the tests to see the failure, then apply the source
patch to see how it fixes the issue.

-Nathan
> 
> >> 2006/9/26, Geir Magnusson Jr. <geir@pobox.com>:
> >>> I really, really like two patches as we discussed on a different
> thread.
> >>>
> >>> That way, I can apply the test patch, show the bug, apply the source
> >>> patch, show it's gone (and then screw up and not commit all the code
> >>> in the patch ;)
> >>>
> >>> Tim was neutral, but didn't care, so there's no opposition to asking
> >>> for two.
> >>>
> >>> geir
> >>>
> >>> On Sep 26, 2006, at 9:29 AM, Denis Kishenko wrote:
> >>>
> >>> > Sometime I make two different diff files (source and test patches),
> >>> > sometime I make the single one. Does it make sense for committers?
> >>> >
> >>> > --------------------------------------------------------------------
> -
> >>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>> > For additional commands, e-mail: harmony-dev-
> help@incubator.apache.org
> >>> >
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>>
> >>>
> >>
> >>
> >> --Denis M. Kishenko
> >> Intel Middleware Products Division
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> 
> --
> 
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message