harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <nbe...@kc.rr.com>
Subject RE: [build] Use Sun 5.0_8 or Eclipse Compiler for automated builds
Date Sun, 10 Sep 2006 18:52:00 GMT

> -----Original Message-----
> From: Geir Magnusson Jr. [mailto:geir@pobox.com]
> Nathan Beyer wrote:
> > I think I have this issue fixed. I modified the 'build-java.xml' script
> to
> > use 'bootclasspath' instead of 'classpath' in the 'javac' task [1].
> 
> 
> Why?  What changed in the Sun compiler that warrants this?
> 
> Can we just switch to the eclipse compiler?

We could switch and personally I'd prefer to. We'd just need to get the ECJ
JAR on Ant's classpath, which we can do by having people copy the JAR to
their Ant lib folder or try to do it dynamically with the build scripts.

-Nathan

> 
> geir
> 
> >
> > Please test it out and let me know if this works. It works for me on
> WinXP
> > and Sun JDK 5.0_8 and resolves the issue mentioned below.
> >
> > [1]
> >
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mak
> e/
> > build-java.xml?r1=440948&r2=441358&diff_format=h
> >
> >> -----Original Message-----
> >> From: Geir Magnusson Jr. [mailto:geir@pobox.com]
> >> Sent: Wednesday, September 06, 2006 10:07 PM
> >> To: harmony-dev@incubator.apache.org
> >> Subject: Re: [build] Use Sun 5.0_8 or Eclipse Compiler for automated
> >> builds
> >>
> >>
> >>
> >> Nathan Beyer wrote:
> >>>> -----Original Message-----
> >>>> From: Richard Liang [mailto:richard.liangyx@gmail.com]
> >>>>
> >>>>  Sun compiler (5.0_8) also has some unexpected behavior. See[1]
> >>>>
> >>>> [1]http://mail-archives.apache.org/mod_mbox/incubator-harmony-
> >>>> dev/200608.mbox/%3c44F2DADE.5060900@gmail.com%3e
> >>>>
> >>> I've found that a second or third "ant build" takes care of it.
> >> LOL
> >>
> >> That's not a solution.
> >>
> >>  > What I've
> >>> noticed though is that the failures are all linking to elements from
> >> classes
> >>> in luni-kernel. I'm looking at it, but I think there are some issues
> >> with
> >>> what's put on the bootclasspath. I've already found one discrepancy
> >> between
> >>> some of our 'luni-kernel' stubs and the spec. The Method.invoke() uses
> a
> >>> vararg and our stub didn't have this.
> >> Cool.
> >>
> >>> -Nathan
> >>>
> >>>
> >>>>> There are a number of places that use ReferenceQueues and Reference,
> >> but
> >>>>> can't be generified because of a bug in the Sun compilers prior
to
> >>>> 5.0_8. At
> >>>>> the end of this email is an example of code that causes a compiler
> >> error
> >>>> in
> >>>>> previous releases. This issue does not affect the Eclipse compiler.
> >> I've
> >>>> run
> >>>>> a full rebuild as of revision 440796 and everything compiles fine
> with
> >>>> both
> >>>>> the Eclipse compiler and Sun 5.0_8 compiler.
> >>>>>
> >>>>>
> >>>>>
> >>>>> -Nathan
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>     private static final ReferenceQueue<Object> cacheQueue
= new
> >>>>> ReferenceQueue<Object>();
> >>>>>
> >>>>>
> >>>>>
> >>>>>     private static final class CacheEntry extends
> >> WeakReference<Object>
> >>>> {
> >>>>>         String key;
> >>>>>
> >>>>>
> >>>>>
> >>>>>         CacheEntry(Object jar, String key, ReferenceQueue<Object>
> >> queue)
> >>>> {
> >>>>>             super(jar, queue);
> >>>>>
> >>>>>             this.key = key;
> >>>>>
> >>>>>         }
> >>>>>
> >>>>>     }
> >>>>>
> >>>>>
> >>>>>
> >>>>>     // ... code using the queue
> >>>>>
> >>>>>
> >>>>>
> >>>>>             CacheEntry entry;
> >>>>>
> >>>>>             // This cast fails on Sun 5.0_7 and prior compilers
> >>>>>
> >>>>>             while ((entry = (CacheEntry)cacheQueue.poll()) != null)
> {
> >>>>>
> >>>>>                 jarCache.remove(entry.key);
> >>>>>
> >>>>>             }
> >>>>>
> >>>>>
> >>>>>
> >>>>>     // . more code
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>> --
> >>>> Richard Liang
> >>>> China Software Development Lab, IBM
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail: harmony-dev-
> help@incubator.apache.org
> >>>
> >>> ---------------------------------------------------------------------
> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message