Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of alexey.v.varlamov@gmail.com
 designates 66.249.82.231 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=E/69NAk+yMKra4gQymtSURD4PjXUZksVxcdlherzPoONizsZx0W0Zu24PxDZ2X47Dk8i3uicYnyM29JJLEbKcEr040H1aLSDikulW0E2z73f0UIY1HHPN9YpEYdx236kMZjBHckNiuh1KFn5GVBOvx/IOO5wMJ8a7abE6qaQCf8=
Message-ID: <f944d83d0608290233g66394d3ax6d34152339491c87@mail.gmail.com>
Date: Tue, 29 Aug 2006 16:33:55 +0700
From: "Alexey Varlamov" <alexey.v.varlamov@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Created: (HARMONY-1295) [classlib][net] flaw in
 setReuseAddrAndReusePort()
In-Reply-To: <44F3E6BB.2050209@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <657651.1156763422386.JavaMail.jira@brutus>
	 <4d0b24970608281841y7a1b370ax93c62abac750c183@mail.gmail.com>
	 <f944d83d0608282257x1e651f5wc39563c20e6b45fe@mail.gmail.com>
	 <4d0b24970608282338i5e57acf2xdac2d889fff2ea13@mail.gmail.com>
	 <44F3E6BB.2050209@gmail.com>

[snip]
>
> Interesting, deep look into code, I find JNI use pointer as the field
> ID, so field-ID of value in Boolean is the same as the one of Integer.
> In this way the code can get a value field of Integer out of a Boolean
> (C pointer is great! :) ). IMO, this is a mis-use but cause no error
> until a strict check is taken. :)

Yes, this appears to be an (unwritten) standard de-facto. DRLVM also
uses fieldIDs to unwrap boxed values, and would silently bear with
such misuse in release mode.

> This is a bug of native code, I agree we should use "booleanValue"
> instead of "intValue", may we raise a JIRA and fix?

JIRA is already there, feel free to attach a patch :) We could apply a
quickfix and continue with design discussion without closing the JIRA.
--
Alexey

> > --
> >> Regards,
> >> Alexey
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >>
> >
> >
>
>
> --
>
> Best Regards!
>
> Jimmy, Jing Lv
> China Software Development Lab, IBM
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org