Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of stepan.mishura@gmail.com
 designates 64.233.162.202 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:mime-version:content-type;
        b=Nnk1PdHIutzhF3gJxzkONfG+5+bIjPZzkv8dDYcnN/LKdwCu4BeKSP1MKZZShJ5DwVRO04pNI2aEzj0e4bXhv6U4uIQexz9l6zTqejsCzTEhltCUsr01bFJDzehL347bn6a0m8kBCs0A7S/iqt+m0/A4EJQw/wZlVr6bHpmzpfg=
Message-ID: <6e47b64f0608140435r79754999kc363c1d7eba9b461@mail.gmail.com>
Date: Mon, 14 Aug 2006 18:35:33 +0700
From: "Stepan Mishura" <stepan.mishura@gmail.com>
To: harmony-dev <harmony-dev@incubator.apache.org>
Subject: Re: svn commit: r431219 - in
 /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/
 java/org/apache/harmony/luni/tests/java/lang/
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_52385_21844500.1155555333679"

------=_Part_52385_21844500.1155555333679
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Nathan,

I saw that you've changed tests layout (consolidated) tests in luni module.
But I don't understand what the purpose for the change. Is this a first step
for migrating to TestNG? (May be I missed something important - sorry for
stupid question then.)

BTW did we agree on that we won't follow directory-based tests layout [1]?
IMHO, not yet. IIRC we agreed that directory-based tests layout is not quite
convenient for our needs and we'll try TestNG. But for me it doesn't mean
that we'll migrate to TestNG for sure. Also I assume that mixed approach
(directory-based layout + annotations) is possible. So it is not time for
doing massive tests moves and merges.

And the minor comment to the commit log. It says: "remove unused folders".
But there are a lot of other unrelated changes. Was it possible to make
separate commits?

Thanks,
Stepan.

[1]
http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html

-----Original Message-----
From: ndbeyer@apache.org [mailto:ndbeyer@apache.org]
Sent: Monday, August 14, 2006 2:56 AM
To: harmony-commits@incubator.apache.org
Subject: svn commit: r431219 - in
/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/
java/org/apache/harmony/luni/tests/java/lang/

Author: ndbeyer
Date: Sun Aug 13 12:55:54 2006
New Revision: 431219

URL: http://svn.apache.org/viewvc?rev=431219&view=rev
Log:
remove unused folders

Removed:
    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/
    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/
Modified:

incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java

incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java

incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/ThreadGroupTest.java

Modified:
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
URL:
http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java?rev=431219&r1=431218&r2=431219&view=diff
==============================================================================


---
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
(original)
+++
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java
Sun Aug 13 12:55:54 2006
@@ -441,7 +441,7 @@
      */
     public void test_parseDoubleLjava_lang_String() {
         assertEquals("Incorrect double returned, expected zero.", 0.0,
Double
-                .parseDouble("2.4703282292062327208828439643411e-324"));
+                .parseDouble("2.4703282292062327208828439643411e-324"), 0.0
);
         assertTrue("Incorrect double returned, expected minimum double.",
Double
                 .parseDouble("2.4703282292062327208828439643412e-324") ==
Double.MIN_VALUE);


Modified:
incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
<SNIP>


------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

------=_Part_52385_21844500.1155555333679--