Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: neutral (asf.osuosl.org: 202.81.18.154 is neither permitted nor
 denied by domain of firepure@gmail.com)
Message-ID: <44F6BB2F.9090606@gmail.com>
Date: Thu, 31 Aug 2006 18:34:23 +0800
From: "Jimmy, Jing Lv" <firepure@gmail.com>
User-Agent: Thunderbird 1.5.0.5 (Windows/20060719)
MIME-Version: 1.0
To: harmony-dev@incubator.apache.org
Subject: Re: [classlib]strings externalization
References: <c79906b30607270353y4dfdb16bw92bc48fed76cb1c0@mail.gmail.com>
	 <c79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com>
	 <c79906b30608030652h554730e4wb244ef1cb354425a@mail.gmail.com>
	 <44DB2AB1.3060601@gmail.com>
	 <c79906b30608100742r5eae880fobf33e5787d35b927@mail.gmail.com>
	 <44DC50DF.7080505@gmail.com>
	 <c79906b30608150801u2ded8916yab8862bba45077d1@mail.gmail.com>
	 <44F3A5BD.6030109@gmail.com>
	 <c79906b30608290343x66098ad6xa38c0b4c6748a699@mail.gmail.com>
	 <44F4ED2E.7090403@gmail.com>
 <c79906b30608300023x65227494v17a27b516eb7c8b5@mail.gmail.com>
In-Reply-To: <c79906b30608300023x65227494v17a27b516eb7c8b5@mail.gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1; format=flowed

Ilya Okomin wrote:
> Hi, Jimmy!
> 
> It's great that you are interested in it!
> Unfortunately there is no automatic externalization generation tool that
> fits our needs. However, you can combine Eclipse externalization tool with
> some manual work to get what is need. You can take a look into the
> [classlib]strings externalization thread [1] for details. Main points
> briefly:
> 1. Using Eclipse externalization tool you can extract all strings from the
> sources. When you process certain source file strings that used for 
> messages
> should be externalized, others should be ignored (as a result, Eclipse mark
> them with non-nls tag).
> 2. Eclipse tool by default suggests you to use keep messages from each 
> class
> in the separate messages.properties file, and keys in the properties file
> will looks like <class_name>.<id>. We've decided to have one messages list
> for each module with keys <module>.<id> (in your case <module> == 
> instrument
> :)). Thus at first you should change common prefix to "<module>.". Next 
> step
> is to configure "Accessor class" field: choose the proper package for
> Messages class and messages.properties file("org.apache.harmony
> .<module>.msgstool").
> 
> What is to take care of:
> 1. Continuation of the numeration of messages. For every new source file 
> you
> process Eclipse tool will reset enumeration, and you should manually set 
> the
> appropriate number for messages. Also it would be better if you avoid
> messages duplication in the list. (Pretty annoying if you have many 
> messages
> in the module and some of them are duplicated)
> 2. Messages formatting. If you have message located on the several source
> code lines - you should concatenate them into one message string and use 
> one
> Messages.getString(..) call. Also messages with arguments are supposed 
> to be
> converted to strings with places for substitution by parameters being
> arguments in Messages.getString() method. E.g. code:
> 
> int param;
> ...
> NullPointerException("foo " + param + " bar");
> 
> supposed to be formatted as
> 
> NullPointerException(Messages.getString("<module>.1", param));
> 
> where "<module>.1=foo {0} bar" in the resource bundle.
> 
> I hope now the process is clear.
> You can find examples of internationalized messages in the [sql] module.
> 
> As for messages in native code, actually I dealt only with java code.
> You may find something interesting for you from the "[drlvm] proposals for
> VM c" thread [2].
> 
> Regards,
> Ilya.
> 
> [1]
> http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200607.mbox/%3cc79906b30607270353y4dfdb16bw92bc48fed76cb1c0@mail.gmail.com%3e 
> 
> [2]
> http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200607.mbox/%3c23951bd90607122308i721c9c6xfcfe786f9d1e26de@mail.gmail.com%3e 
> 
> 

Thanks Ilya, I'll apply patch soon. I deal with Java code only this 
time, it is simple that I only find 3 strings :) I'll put them in 
messages.properties under instrument with name "instrument.1(2,3)" and 
update codes.
Instrument also have an console output string, I suggest also put it to 
property file so it can be internationalization as well. Then there are 
4 total.
And strings in native code may be refactored if we have conclusion of 
native internationalization.


<snip>


-- 

Best Regards!

Jimmy, Jing Lv
China Software Development Lab, IBM

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org