Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 81857 invoked from network); 14 Aug 2006 12:57:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Aug 2006 12:57:10 -0000 Received: (qmail 7679 invoked by uid 500); 14 Aug 2006 12:57:08 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 7626 invoked by uid 500); 14 Aug 2006 12:57:08 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 7606 invoked by uid 99); 14 Aug 2006 12:57:08 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Aug 2006 05:57:08 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of alexei.zakharov@gmail.com designates 64.233.162.192 as permitted sender) Received: from [64.233.162.192] (HELO nz-out-0102.google.com) (64.233.162.192) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Aug 2006 05:57:07 -0700 Received: by nz-out-0102.google.com with SMTP id v1so346651nzb for ; Mon, 14 Aug 2006 05:56:46 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lj2KjwaFmNb1jMhtqXl72CIaL9C29o6R8zB6OHzE3LMiyXAXhxcjnpt7Fm+Rydt96uCNMQVyJWfZPtdn/kX+2IVj8RBxG/CfNuEfdBBojhRmnTyMoZFuGce7qh2pa0+9IkTir9k0lyPyUCUQRcGyyLwNMlDaAkXYtLs6sOSWkmw= Received: by 10.65.95.14 with SMTP id x14mr6814829qbl; Mon, 14 Aug 2006 05:56:46 -0700 (PDT) Received: by 10.64.131.4 with HTTP; Mon, 14 Aug 2006 05:56:46 -0700 (PDT) Message-ID: <2c9597b90608140556x693790beic950512a93fa88f8@mail.gmail.com> Date: Mon, 14 Aug 2006 16:56:46 +0400 From: "Alexei Zakharov" To: harmony-dev@incubator.apache.org Subject: Re: svn commit: r431219 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ impl/ java/org/apache/harmony/luni/tests/java/lang/ In-Reply-To: <44E06ED0.6030006@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <6e47b64f0608140435r79754999kc363c1d7eba9b461@mail.gmail.com> <44E06ED0.6030006@pobox.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Our current builds does not allow to run TestNG 5.0 yet. And AFAIK we have not finished the discussion about directory based approach vs metadata based approach. With Best Regards, 2006/8/14, Geir Magnusson Jr : > I haven't been following the test discussion too closely, but please > don't make it so that only tooling can tell us what is what... > > geir > > > Stepan Mishura wrote: > > Hi Nathan, > > > > I saw that you've changed tests layout (consolidated) tests in luni module. > > But I don't understand what the purpose for the change. Is this a first > > step > > for migrating to TestNG? (May be I missed something important - sorry for > > stupid question then.) > > > > BTW did we agree on that we won't follow directory-based tests layout [1]? > > IMHO, not yet. IIRC we agreed that directory-based tests layout is not > > quite > > convenient for our needs and we'll try TestNG. But for me it doesn't mean > > that we'll migrate to TestNG for sure. Also I assume that mixed approach > > (directory-based layout + annotations) is possible. So it is not time for > > doing massive tests moves and merges. > > > > And the minor comment to the commit log. It says: "remove unused folders". > > But there are a lot of other unrelated changes. Was it possible to make > > separate commits? > > > > Thanks, > > Stepan. > > > > [1] > > http://incubator.apache.org/harmony/subcomponents/classlibrary/testing.html > > > > -----Original Message----- > > From: ndbeyer@apache.org [mailto:ndbeyer@apache.org] > > Sent: Monday, August 14, 2006 2:56 AM > > To: harmony-commits@incubator.apache.org > > Subject: svn commit: r431219 - in > > /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test: api/ > > impl/ > > java/org/apache/harmony/luni/tests/java/lang/ > > > > Author: ndbeyer > > Date: Sun Aug 13 12:55:54 2006 > > New Revision: 431219 > > > > URL: http://svn.apache.org/viewvc?rev=431219&view=rev > > Log: > > remove unused folders > > > > Removed: > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/api/ > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/impl/ > > Modified: > > > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java > > > > > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java > > > > > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/ThreadGroupTest.java > > > > > > Modified: > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java > > > > URL: > > http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java?rev=431219&r1=431218&r2=431219&view=diff > > > > ============================================================================== > > > > > > > > --- > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java > > > > (original) > > +++ > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/DoubleTest.java > > > > Sun Aug 13 12:55:54 2006 > > @@ -441,7 +441,7 @@ > > */ > > public void test_parseDoubleLjava_lang_String() { > > assertEquals("Incorrect double returned, expected zero.", 0.0, > > Double > > - .parseDouble("2.4703282292062327208828439643411e-324")); > > + .parseDouble("2.4703282292062327208828439643411e-324"), > > 0.0 > > ); > > assertTrue("Incorrect double returned, expected minimum double.", > > Double > > .parseDouble("2.4703282292062327208828439643412e-324") == > > Double.MIN_VALUE); > > > > > > Modified: > > incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java > > > > > > > > > > ------------------------------------------------------ > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > -- Alexei Zakharov, Intel Middleware Product Division --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org