Return-Path: 
 <harmony-dev-return-12685-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org
Received: (qmail 21256 invoked from network); 30 Aug 2006 13:51:21 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 30 Aug 2006 13:51:21 -0000
Received: (qmail 12095 invoked by uid 500); 30 Aug 2006 13:51:19 -0000
Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org
Received: (qmail 11970 invoked by uid 500); 30 Aug 2006 13:51:18 -0000
Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:harmony-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:harmony-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:harmony-dev@incubator.apache.org>
List-Id: <harmony-dev.incubator.apache.org>
Reply-To: harmony-dev@incubator.apache.org
Delivered-To: mailing list harmony-dev@incubator.apache.org
Received: (qmail 11959 invoked by uid 99); 30 Aug 2006 13:51:18 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2006 06:51:18 -0700
X-ASF-Spam-Status: No, hits=1.8 required=10.0
	tests=PLING_PLING,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: 195.212.29.134 is neither permitted nor
 denied by domain of mark.hindess@googlemail.com)
Received: from [195.212.29.134] (HELO mtagate1.uk.ibm.com) (195.212.29.134)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2006 06:51:17 -0700
Received: from d06nrmr1407.portsmouth.uk.ibm.com
 (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185])
	by mtagate1.uk.ibm.com (8.13.7/8.13.7) with ESMTP id k7UDouCW181152
	for <harmony-dev@incubator.apache.org>; Wed, 30 Aug 2006 13:50:56 GMT
Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com
 [9.149.37.228])
	by d06nrmr1407.portsmouth.uk.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id
 k7UDqwDa925738
	for <harmony-dev@incubator.apache.org>; Wed, 30 Aug 2006 14:52:58 +0100
Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
 k7UDot71014216
	for <harmony-dev@incubator.apache.org>; Wed, 30 Aug 2006 14:50:55 +0100
Received: from anaheim.local (anaheim.hursley.ibm.com [9.20.183.13])
	by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
 k7UDotv7014213
	for <harmony-dev@incubator.apache.org>; Wed, 30 Aug 2006 14:50:55 +0100
Message-Id: <200608301350.k7UDotv7014213@d06av02.portsmouth.uk.ibm.com>
X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-7) with nmh-1.1
In-reply-to: <6e47b64f0608292203w34129210ra72dd4c66463e53c@mail.gmail.com> 
References: <6e47b64f0608292203w34129210ra72dd4c66463e53c@mail.gmail.com>
Comments: In-reply-to "Stepan Mishura" <stepan.mishura@gmail.com>
   message dated "Wed, 30 Aug 2006 12:03:26 +0700."
From: Mark Hindess <mark.hindess@googlemail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [classlib][logging] a test suite shouldn't touch any of JRE
 config files!!! 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 30 Aug 2006 14:50:24 +0100
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N


On 30 August 2006 at 12:03, "Stepan Mishura" <stepan.mishura@gmail.com>
wrote:
>
> Hi,
> 
> I was browsing thought logging tests and realized that running logging test
> suite cause updates of tested JRE configuration.
> The ant script changes jre/lib/logging.properties file by:
> 
>     <target name="copy.resources">
>         <copy todir="${hy.jdk}/jre/lib" overwrite="yes" flatten="yes">
>             <fileset dir="${hy.logging.src.main.java}">
>                 <include name="**/logging.properties" />
>             </fileset>
>         </copy>
>     </target>

The 'test' target depends on 'build' which in turn depends on the above
'copy.resources' target.  So this seems perfectly reasonable to me.

It's copying it to the jre to make the jre complete.  It is part of the 
build not the test process.

If it was copying to test.jre.home I'd be worried but I don't really see
why this should be a problem.

Regards,
 Mark.

> I do believe that we shouldn't do testing in this way - if a test requires
> special env. configuration(different from JRE's default) the test suite
> shouldn't *hack* JRE config files. We should consider dynamic env.
> reconfiguration. For example, for this particular case is there any problem
> with using LogManager.readConfiguration(InputStream) to reinitialize the
> logging properties?
> Also keep in mind that the test suite is expected to be run against some
> compatible implementation. I think nobody is going to reinstall Sun's JRE
> each time after running Harmony test suite.
> 
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
> 
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> ------=_Part_17401_4283173.1156914206767--



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org