harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject Re: [jira] Created: (HARMONY-1295) [classlib][net] flaw in setReuseAddrAndReusePort()
Date Tue, 29 Aug 2006 09:33:55 GMT
[snip]
>
> Interesting, deep look into code, I find JNI use pointer as the field
> ID, so field-ID of value in Boolean is the same as the one of Integer.
> In this way the code can get a value field of Integer out of a Boolean
> (C pointer is great! :) ). IMO, this is a mis-use but cause no error
> until a strict check is taken. :)

Yes, this appears to be an (unwritten) standard de-facto. DRLVM also
uses fieldIDs to unwrap boxed values, and would silently bear with
such misuse in release mode.

> This is a bug of native code, I agree we should use "booleanValue"
> instead of "intValue", may we raise a JIRA and fix?

JIRA is already there, feel free to attach a patch :) We could apply a
quickfix and continue with design discussion without closing the JIRA.
--
Alexey

> > --
> >> Regards,
> >> Alexey
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >>
> >
> >
>
>
> --
>
> Best Regards!
>
> Jimmy, Jing Lv
> China Software Development Lab, IBM
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message