harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Rebriy" <pavel.reb...@gmail.com>
Subject Re: [drlvm] sanity check - can someone build from svn and test ActiveMQ?
Date Fri, 18 Aug 2006 10:28:08 GMT
Ok, I'll try to explain it.

Function vf_resolve_class with true as the second parameter asks class
loader to load a class with a given class name. If the second parameter
equals to false, function just checks if a given class is loaded, and get it
if it is.

The patch claims that if class loader tries to load a given class and fails
and then asks it to lookup among loaded classes it appears to be
successfully loaded. That is a class is failed to load, but it is
successfully loaded in VM. It could work only is a class loader is bugged.

On 17/08/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>
> Right - what I was worried about was that I *thought* that
> HARMONY-956 got me to where Gergory is describing, but he's applying
> HARMONY-1179.
>
> I'll just stop worrying about this for the snapshot, post it, and
> move on w/ 1179 and keep going.
>
> Thanks all for looking into this - I could *swear* that 956 had a
> visible effect, but I was clearly mistaken.
>
> And what is "dutty hacking"? :)
>
> geir
>
>
> On Aug 17, 2006, at 8:11 AM, Pavel Rebriy wrote:
>
> > Anton, your patch is a dutty hacking.
> >
> > With and without the patch ActiveMQ crashes as Gregory described.
> >
> > On 17/08/06, Anton Luht <anton.luht@gmail.com> wrote:
> >>
> >> Hello,
> >>
> >> Please try to apply patch
> >>
> >> Index: vm/vmcore/src/verifier/ver_utils.cpp
> >> ===================================================================
> >> --- vm/vmcore/src/verifier/ver_utils.cpp        (revision 432184)
> >> +++ vm/vmcore/src/verifier/ver_utils.cpp        (working copy)
> >> @@ -1391,6 +1391,9 @@
> >>
> >>      // get stack reference class
> >>      class_handler source = vf_resolve_class( constraint->source,
> >> true,
> >> ctex );
> >> +    if(source == NULL) {
> >> +       source = vf_resolve_class( constraint->source, false, ctex );
> >> +    }
> >>      if( !source ) {
> >>          VERIFY_DEBUG( "verifying class " << class_get_name( ctex-
> >> >m_class
> >> )
> >>              << " (method " << method_get_name( constraint->method
)
> >>
> >>
> >>
> >> Unfortunately I cannot attach it to the  JIRA issue because the
> >> issue is
> >> closed.
> >>
> >> On 8/16/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> >> > I'm trying to create snapshots, and when testing w/ ActiveMQ, I
> >> still
> >> > have the same problems w/ ActiveMQ as reported originally in
> >> HARMONY-956.
> >> >
> >> > Can someone do a sanity check?  it's a release build.
> >> >
> >> > geir
> >> >
> >> >
> >> ---------------------------------------------------------------------
> >> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> > To unsubscribe, e-mail: harmony-dev-
> >> unsubscribe@incubator.apache.org
> >> > For additional commands, e-mail: harmony-dev-
> >> help@incubator.apache.org
> >> >
> >> >
> >>
> >>
> >> --
> >> Regards,
> >> Anton Luht,
> >> Intel Middleware Products Division
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-
> >> help@incubator.apache.org
> >>
> >>
> >
> >
> > --
> > Best regards,
> > Pavel Rebriy
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Best regards,
Pavel Rebriy

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message