harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang" <zhanghuang...@gmail.com>
Subject Re: [continuum] BUILD FAILURE: Classlib/win.ia32 Build/Test
Date Thu, 03 Aug 2006 13:36:39 GMT
On 8/3/06, Geir Magnusson Jr <geir@pobox.com> wrote:

>
>
> Paulex Yang wrote:
> > Andrew Zhang wrote:
> >> The failure is caused by Harmony-1040.
> >> The updated hostEquals(URL u1, URL u2) introduces a new bug:
> >> It returns true when u1.host = null and u2.host = "" while it should
> >> return
> >> false.
> >
> >> Sorry for the mistake caused by my patch. I'll update a new patch to
> >> solve
> >> this problem.
> > Great, thank you to find this, Andrew. And don't need to say sorry, it's
> > me who takes responsibility on this and then owes the beer:-(.
> >
>
>
> Out of curiosity, did either of you run the test suite on windows before
> offering the patch or committing it?  This isn't about "blame" or such,
> but about learning about how to make a better process....


I did run luni and nio module test on both windows and linux, but security
module fails...

It's a lesson for me. I'll pay more attention next time.



> There's no harm done - it was found fast, and fixed fast, so kudos to
> you guys for working together on that.
>
> geir
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Andrew Zhang
China Software Development Lab, IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message