harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [vote] HARMONY-1225 : Assorted fixes and enhancements for AWT and Swing
Date Wed, 30 Aug 2006 15:10:37 GMT


Mark Hindess wrote:
> On 30 August 2006 at 10:54, "Geir Magnusson Jr." <geir@pobox.com> wrote:
>> Ok, but the correct way here is probably not a completely new patch, but 
>> one that can follow the original patch with fix-ups....
> 
> 
> I don't think I understand what you mean.  So I'd do:
> 
> 1) apply the original patch with --force and create lots of .rej files
> 2) apply a patch to remove the "legitimate" .rej files?
> 3) check for any remaining .rej files which would indicate real errors?
> 
> This sounds crazy to me and usually I'm pretty open about hacking things
> around. ;-)
> 
> I was imagining a "new" patch which would be identical to the old one
> but with the hunks that would have been rejected in the old one removed.
> And possibly a new patch which clearly identifies any new changes that
> are required to create something working/consistent to check 
> in.

That's what I thought you meant, but it isn't what I just voted for...

If an individual that knows the original patch sends a patch that 
produces the same end state following the path you find crazy, I'm fine 
with it.

geir

> 
> Regards,
>  Mark.
> 
>> geir
>>
>>
>> Ivanov, Alexey A wrote:
>>> Mark,
>>>
>>> I'll clean up the patch from those fixes which were applied during HTML
>>> integration, and attach the new one.
>>>
>>> A quick look shows that Sergey is right, and many Swing fixes have been
>>> applied already.
>>>
>>> Regards,
>>> Alexey.
>>>
>>> --
>>> Alexey A. Ivanov
>>> Intel Middleware Product Division
>>>
>>>
>>>> -----Original Message-----
>>>> From: Mark Hindess [mailto:mark.hindess@googlemail.com]
>>>> Sent: Wednesday, August 30, 2006 4:17 PM
>>>> To: harmony-dev@incubator.apache.org
>>>> Subject: Re: [vote] HARMONY-1225 : Assorted fixes and enhancements for
>>> AWT
>>>> and Swing
>>>>
>>>>
>>>> On 30 August 2006 at 14:02, "Sergey Soldatov"
>>>> <sergey.soldatov@gmail.com> wrote:
>>>>> Actually all these rejects were integrated during Swing text
>>>>> integration and they doesn't matter.
>>>> Ok, but it would still be more reassuring to have a clean patch.
>>>> Currently, the only way I'd be confident that the patch has been
>>>> consistently applied would be to check the rejects by hand.  I'm
>>>> assuming those who create the patch could do this quicker than
>>>> any of committers.
>>>>
>>>> -Mark.
>>>>
>>>>> On 8/30/06, Mark Hindess <mark.hindess@googlemail.com> wrote:
>>>>>> +1
>>>>>>
>>>>>> However, I'd also like to hear the end of the dependency saga.
>>>>>>
>>>>>> It would also be useful (when the vote is complete) to have an up
>>> to
>>>>>> date patch.  The current patch has lots of rejects due to
>>> "previously
>>>>>> applied" hunks, etc.  It will be quite difficult to integrate in
>>> its
>>>>>> current state.
>>>>>>
>>>>>> Regards,
>>>>>> Mark.
>>>>>>
>>>>>> On 28 August 2006 at 1:50, Geir Magnusson Jr <geir@pobox.com>
>>> wrote:
>>>>>>> All is in order and in SVN for Harmony-1225 wrt BCC and ACQ.
>>>>>>>
>>>>>>> Please vote to accept or reject this set of patches and fixes
>>> into
>>>> the
>>>>>>> Apache Harmony class library :
>>>>>>>
>>>>>>> [ ] + 1 Accept
>>>>>>> [ ] -1 Reject  (provide reason below)
>>>>>>>
>>>>>>> Lets let this run a minimum of 3 days unless a) someone states
>>> they
>>>> need
>>>>>>> more time or b) we get all committer votes before then.
>>>>>>>
>>>>>>> geir
>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message