harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: [drlvm] src/test side-by-side with vm and build?
Date Tue, 15 Aug 2006 05:11:30 GMT


Nathan Beyer wrote:
> We definitely need to do something. I spent the last few hours trying to
> build/add a "smoke test" for a patch [1] and have gotten absolutely no
> where. I had to change the "smoke.test.xml" file to compile against the JRE
> being built, so I could get it to compile, but after that I couldn't get it
> to PASS. I've given up for the moment. How do these tests work?

Um - that's odd.  I've just dropped tests in there and they just worked.

> 
> Can't I just create a JUnit TestCase, drop it into a test folder and have it
> run against the JRE that was built? The smoke tests just seem like an ad hoc
> JUnit framework. Do we need that?

Well, how about this - can you start a JUnit based framework in the src/
directory for now, and we can join things at some point?

geir

> 
> -Nathan
> 
> [1] http://issues.apache.org/jira/browse/HARMONY-1144
> 
>> -----Original Message-----
>> From: Geir Magnusson Jr [mailto:geir@pobox.com]
>> Sent: Monday, August 14, 2006 10:31 PM
>> To: harmony-dev@incubator.apache.org
>> Subject: Re: [drlvm] src/test side-by-side with vm and build?
>>
>> No.  Please.  But keep in mind the stuff in src/ - how to build and wrap
>> those in JUnit / TestNG....
>>
>> geir
>>
>>
>> Nathan Beyer wrote:
>>> So, I presume there wouldn't be a huge problem with suggestions for
>>> adjusting the layout and using JUnit for the "smoke" tests.
>>>
>>> -Nathan
>>>
>>>> -----Original Message-----
>>>> From: Geir Magnusson Jr [mailto:geir@pobox.com]
>>>> Sent: Monday, August 14, 2006 1:46 PM
>>>> To: harmony-dev@incubator.apache.org
>>>> Subject: Re: [drlvm] src/test side-by-side with vm and build?
>>>>
>>>>
>>>>
>>>> Zakirov, Salikh wrote:
>>>>> Hi,
>>>>>
>>>>> in the below commit Geir has added several dozens files
>>>>> under
>>>>>
>>>>> 	drlvm/trunk/src/test
>>>>>
>>>>> Since we have two directories on the top-level, build with build
>>>>> system, and vm with everything else (sources, tests, documentation),
>>>>> it seems very confusing to have 'src' directory at the top level.
>>>>>
>>>> Yep - I just wanted to park them somewhere as I wanted to close the
>>>> JIRAs that they came in.  I thought that putting them in a conventional
>>>> place like 'src/test' would cause a violent allergic reaction in people
>>>> used to the unique innovation that is the DRLVM layout :)
>>>>
>>>>> Some time ago DRLVM team had very hot debates on directory structure,
>>>>> and we ended up with following structure:
>>>>>
>>>>>      drlvm/trunk
>>>>>      + vm
>>>>>         + vmcore
>>>>>         + jitrino
>>>>>         + ...       (other components)
>>>>>         + doc       (documentation)
>>>>>         + tests     (tests)
>>>>>         + include   (header files)
>>>>>      + build        (build system)
>>>>>
>>>>> The tests that are now checked into src/test look like they are put to
>> a
>>>>> wrong place.
>>>>> More correct place would be something like
>>>>>
>>>>> 	vm/tests/verifier
>>>>>
>>>>> Pavel, could you suggest a convenient place for your verifier tests?
>>>> Actually, we need to come up with a real test framework for these, and
>>>> hopefully pull the other tests out to join them.  I thought I brought
>>>> this up in a JIRA or note to the dev list.
>>>>
>>>> While we're talking about it, should we consider a fresh layout for
>>>> DRLVM?  Maybe we can switch to a make-based build at the same time...
>>>> right now, the layout w/in vm/ is somewhat arbitrary :
>>>>
>>>> 1) There is an include directory in parallel with the modules
>>>>
>>>>     vm/include/*.h
>>>>
>>>> 2) Some modules have their own include directories  (vm/vmcore/include)
>>>>
>>>> 3) Some don't (vm/em)
>>>>
>>>> 4) Some modules have src near the top :
>>>>
>>>>    vm/em/src
>>>>
>>>> 5) Some don't
>>>>
>>>>    vm/tests/smoke/
>>>>
>>>> 6) Some modules have strange branches by language deep in the path :
>>>>
>>>>    vm/vmcore/src/kernel_classes
>>>>                             /javasrc
>>>>                             /native
>>>>
>>>> What do you think?
>>>>
>>>> geir
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message