harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy, Jing Lv" <firep...@gmail.com>
Subject Re: [classlib][support] Using new framework for testing serialization (was: Re: [jira] Updated: (HARMONY-1098) [classlib][instrument]Add tests for UnmodifiableClassException and IllegalClassFormatException)
Date Fri, 11 Aug 2006 02:39:35 GMT
Stepan Mishura wrote:
> On 8/10/06, Jimmy, Jing Lv wrote:
>>
>> Stepan Mishura wrote:
>> <snip>
>> >> BufferOverflowException());
>> >> >
>> >> >
>> >> > But then you have to move generated file to the appropriate place by
>> >> hands.
>> >> > Is this convenient?
>> >> >
>> >>
>> >> Hi Stepan,
>> >>
>> >>     IMO, most ser file should be put into a certain directory, so the
>> >> the appropriate directory is always there.
>> >>
>> >>     I'd like to add a new method to the framework as:
>> >>
>> >> public static void createGoldenFile(TestCase test,Object object)
>> >> throws  IOException {
>> >>     createGoldenFile("src/test/resources/serialization",test,object);
>> >> }
>> >
>> >
>> > But if 'root' param is relative path them the generated file is placed
>> in
>> > 'bin' (i.e. <module_root>/bin/test).  folder. Am I right? So you 
>> have to
>> > move it by hands anyway to
>> <module_root>/src/test/resources/serialization
>> > folder.
>> >
>>
>> Ah sorry, I only test it on eclipse. Yes, if run on ant, it would
>> properly be "<module_root>/bin/test".
>>
>> IMO, mostly, people write code and create file once (for me, on
>> eclipse), so it is still a convenience if the framework offer such 
>> method.
>>
>> And for people who use ant to run test, still can offer a method  for
>> that, e.g.
>> public static void createGoldenFileUsingAnt(TestCase test,Object object)
>>    throws  IOException {
>> createGoldenFile("../../src/test/resources/serialization",test,object);
>> }
>>
>> Am I right? Thanks! :)
> 
> 
> IMHO the framework shouldn't contain methods that work for selected tool
> only.
> 

OK, I'm fine with it (I shall make one on my own workspace :) ).

So I'll make a new patch for Harmony-1098 according to new framework.


> Thanks,
> Stepan.
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 


-- 

Best Regards!

Jimmy, Jing Lv
China Software Development Lab, IBM

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message