harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paulex Yang <paulex.y...@gmail.com>
Subject Re: [continuum] BUILD FAILURE: Classlib/win.ia32 Build/Test
Date Thu, 03 Aug 2006 12:28:18 GMT
Sorry for that...I checked in the patch in LUNI, and I ran LUNI test on 
both platform(win/linux), but it caused security module fail...

But it's really hard to run all harmony tests for only several lines of 
update(it lasts half hour on my T43, and I have nothing to do with it 
during this....), I really want to hear some good idea about this...

Geir Magnusson Jr wrote:
> Paulex Yang wrote:
>   
>> Andrew Zhang wrote:
>>     
>>> The failure is caused by Harmony-1040.
>>> The updated hostEquals(URL u1, URL u2) introduces a new bug:
>>> It returns true when u1.host = null and u2.host = "" while it should
>>> return
>>> false.
>>>       
>>> Sorry for the mistake caused by my patch. I'll update a new patch to
>>> solve
>>> this problem.
>>>       
>> Great, thank you to find this, Andrew. And don't need to say sorry, it's
>> me who takes responsibility on this and then owes the beer:-(.
>>
>>     
>
>
> Out of curiosity, did either of you run the test suite on windows before
> offering the patch or committing it?  This isn't about "blame" or such,
> but about learning about how to make a better process....
>
> There's no harm done - it was found fast, and fixed fast, so kudos to
> you guys for working together on that.
>
> geir
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>   


-- 
Paulex Yang
China Software Development Lab
IBM


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message