harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Liang <richard.lian...@gmail.com>
Subject Re: [classlib][luni] Enhance the functionalities provided by BitSet
Date Thu, 03 Aug 2006 06:40:40 GMT


Spark Shen wrote:
> Hi All:
>
> IMHO, EnumSet provides a set view of enum types. According to its 
> spec, "Enum sets are represented internally as bit vectors".
> To avoid to re-invent the wheel, it could be more reasonable to 
> utilize java.util.BitSet class to support the implementation of EnumSet.
>
Agree :-)

> While current API methods provided by BitSet is not enough, I need to 
> extend the function provided by BitSet. There are 2 options:
> 1. Implement these extension methods in BitSet directly as package 
> private methods
> 2. Construct a package private utility class in 
> org.apache.harmony.luni.util package, and implement extensions in this 
> implementation class.
>
> I prefer the first option, since there is not many classes need these 
> extension. If no objections, I will adopt the first schema.
>
IMHO, it depends on the relationship between the extended functions and 
the whole class. Would you please provide more detail information? 
Thanks a lot.

Richard.
> Best regards.
>

-- 
Richard Liang
China Software Development Lab, IBM 



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message