harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zakirov, Salikh" <salikh.zaki...@intel.com>
Subject [general] Commit comments
Date Wed, 02 Aug 2006 13:50:41 GMT
Geir,

I believe it is probably unintentional, but you
have forgot to include any comment on what the change
does to the code.

I think we should strive to make commit messages
self-sufficient. Specifying JIRA issues can be nice,
but in the long run, it is not very convenient
to have to look up external database just to find
out what the change is about.

Can we agree on principles how to construct
commit messages?

--
Salikh Zakirov, Intel Middleware Products Division 


-----Original Message-----
From: geirm@apache.org [mailto:geirm@apache.org] 
Sent: Wednesday, August 02, 2006 1:44 AM
To: harmony-commits@incubator.apache.org
Subject: svn commit: r427749 -
/incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/jni/jni.cpp

Author: geirm
Date: Tue Aug  1 14:43:57 2006
New Revision: 427749

URL: http://svn.apache.org/viewvc?rev=427749&view=rev
Log:
HARMONY-835 

committed patch and tested on linux

Would be nice to have test cases to illustrate the problems...

Modified:
    incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/jni/jni.cpp

Modified:
incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/jni/jni.cpp
URL:
http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/v
mcore/src/jni/jni.cpp?rev=427749&r1=427748&r2=427749&view=diff
========================================================================
======
--- incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/jni/jni.cpp
(original)
+++ incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/jni/jni.cpp Tue
Aug  1 14:43:57 2006
@@ -810,7 +810,7 @@
         return 0;
     }
 
-    CallVoidMethodA(env, new_handle, methodID, args);
+    CallNonvirtualVoidMethodA(env, new_handle, clazz, methodID, args);
     if (ExceptionCheck(env))
         return NULL;
     else

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message