harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject [classlib] unused jpeg code? (was Re: [jira] Updated: (HARMONY-1046) Remove jpegint.h from awt native sources)
Date Fri, 04 Aug 2006 16:33:25 GMT

On a related note, is JpegEncoder.c actually used.  I thought it was
excluded from each relevant build.xml in the original contribution?
If it isn't used, why is it in the code base?  Future use?  Testing?

Regards,
-Mark.

On 4 August 2006 at 6:51, "Alexey Petrenko (JIRA)" <jira@apache.org> wrote:
>      [ http://issues.apache.org/jira/browse/HARMONY-1046?page=all ]
> 
> Alexey Petrenko updated HARMONY-1046:
> -------------------------------------
> 
>     Attachment: JIRA1046.diff
> 
> jpegint.h was included in JpegEncoder.c and JpegDecoder.c. But it was not use
> d in JpegEncoder.c at all.
> 
> JpegDecoder.c used MIN and MAX macros from it. I've removed jpegint.h from th
> e include list and implemented simple MIN and MAX macros.
> 
> > Remove jpegint.h from awt native sources
> > ----------------------------------------
> >
> >                 Key: HARMONY-1046
> >                 URL: http://issues.apache.org/jira/browse/HARMONY-1046
> >             Project: Harmony
> >          Issue Type: Bug
> >          Components: Classlib
> >            Reporter: Alexey Petrenko
> >            Priority: Minor
> >         Attachments: JIRA1046.diff
> >
> >
> > AWT native jpeg encoder and decoder are using jpegint.h. But not all the jp
> eg library distributions has this header file.
> > Evaluation shown that this file can be easily removed from the encoder and 
> decoder. 
> > So we should do this.
> > I'll prepare patch shortly.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http:
> //issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
> 
>         



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message