harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <nbe...@kc.rr.com>
Subject RE: [drlvm] newlines in .cpp and .h files
Date Wed, 16 Aug 2006 03:50:25 GMT
I looked at the files and there are any properties set, so I guess SVN isn't
taking care of anything in this case. It wasn't my editor that changed
anything (Eclipse) it was that the patch was submitted with CRLF endings.

I looked at some of the native source files in classlib and everyone that I
found was using the CRLF. The opposite seems to be true for all of the DRLVM
source files.

I set the SVN property on the atomics.h and atomics.ccp. Let me know if that
fixes the issue for you. If it does, we can do a mass property set or just
set the properties of files as they change.

-Nathan

> -----Original Message-----
> From: Nathan Beyer [mailto:nbeyer@kc.rr.com]
> Sent: Tuesday, August 15, 2006 9:51 PM
> To: harmony-dev@incubator.apache.org
> Subject: RE: [drlvm] newlines in .cpp and .h files
> 
> All of the files in the commit or just one?
> 
> I thought SVN took care of this via the svn:eol-style = native property?
> I'll check the files, maybe this isn't set there.
> 
> -Nathan
> 
> > -----Original Message-----
> > From: news [mailto:news@sea.gmane.org] On Behalf Of Salikh Zakirov
> > Sent: Tuesday, August 15, 2006 2:20 AM
> > To: harmony-dev@incubator.apache.org
> > Subject: [drlvm] newlines in .cpp and .h files
> >
> > Nathan,
> >
> > your last commit
> >
> >   r431519 | ndbeyer | 2006-08-15 07:46:26 +0400 (Tue, 15 Aug 2006) | 1
> > line
> >   Apply patch for HARMONY-1144: [j.u.c integration with DRLVM - step#1]:
> > implement getFieldOffset and modify compareAndSet<*> methods
> >
> > changed the newlines of the touched files from LF to CRLF.
> >
> > Could you please configure your editor to prevent converting line
> breaks?
> >
> > And could you please commit the back conversion to LF line endings?
> >
> > Thanks!
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message