Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 40347 invoked from network); 6 Jul 2006 13:03:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Jul 2006 13:03:42 -0000 Received: (qmail 71143 invoked by uid 500); 6 Jul 2006 13:03:38 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 71099 invoked by uid 500); 6 Jul 2006 13:03:38 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 71088 invoked by uid 99); 6 Jul 2006 13:03:38 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2006 06:03:38 -0700 X-ASF-Spam-Status: No, hits=1.9 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 202.81.18.154 is neither permitted nor denied by domain of paulex.yang@gmail.com) Received: from [202.81.18.154] (HELO ausmtp05.au.ibm.com) (202.81.18.154) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2006 06:03:37 -0700 Received: from sd0208e0.au.ibm.com (d23rh904.au.ibm.com [202.81.18.202]) by ausmtp05.au.ibm.com (8.13.6/8.13.6) with ESMTP id k66D69Rf2273382 for ; Thu, 6 Jul 2006 23:06:09 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.250.242]) by sd0208e0.au.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k66D6bOx223586 for ; Thu, 6 Jul 2006 23:06:37 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k66D3E6M011653 for ; Thu, 6 Jul 2006 23:03:14 +1000 Received: from d23m0011.cn.ibm.com ([9.181.32.74]) by d23av01.au.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k66D3Dlk010686 for ; Thu, 6 Jul 2006 23:03:13 +1000 Received: from [127.0.0.1] ([9.181.106.114]) by d23m0011.cn.ibm.com (Lotus Domino Release 6.5.5HF262) with ESMTP id 2006070621022818-5304 ; Thu, 6 Jul 2006 21:02:28 +0800 Message-ID: <44AD09E3.5000008@gmail.com> Date: Thu, 06 Jul 2006 21:02:27 +0800 From: Paulex Yang User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: harmony-dev@incubator.apache.org Subject: Re: svn commit: r419522 - in /incubator/harmony/enhanced/classlib/trunk/modules/nio: .classpath build.xml make/hyproperties.xml src/test/java/common/ src/test/java/common/org/ src/test/java/linux/ src/test/java/org/ src/test/java/windows/ References: <20060706112029.0D8FC1A981A@eris.apache.org> <44ACFA22.2080303@googlemail.com> In-Reply-To: <44ACFA22.2080303@googlemail.com> X-MIMETrack: Itemize by SMTP Server on D23M0011/23/M/IBM(Release 6.5.5HF262 | April 5, 2006) at 06/07/2006 21:02:28, Serialize by Router on D23M0011/23/M/IBM(Release 6.5.5HF262 | April 5, 2006) at 06/07/2006 21:03:12, Serialize complete at 06/07/2006 21:03:12 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi, George I've read that thread, and I agree with you that the test layout is an issue worthing consideration, but before heading into the discussion on test convention(again), I want to have a look at TestNG at first so that I can have more value-add to that thread. But on the other side, I've committed (to Andrew and Jimmy) that I'll help to address the platform dependent nio tests, and I guess they may have got quite a few such kind of tests in hand(I've been urged several times on the list after my commitment :( ), and IMO it is not necessary to stop all related work during the discussion, I for sure have no objection to refactor them later (I promise I will volunteer to do that, at least for NIO module) if TestNG is identified at last as a better choice. George Harley wrote: > Hi Mark, > > From what I can tell this JIRA hasn't really achieved much apart from > pushing code around the repository and breaking at least one patch > (HARMONY-755). It would be great if you or Paulex (and everyone in > fact) could comment in the "[classlib] Testing conventions - a > proposal" thread [1] about this. > > Thanks, > George > > [1] > http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200607.mbox/%3c44ABB451.30806@googlemail.com%3e > > > > > hindessm@apache.org wrote: >> Author: hindessm >> Date: Thu Jul 6 04:20:27 2006 >> New Revision: 419522 >> >> URL: http://svn.apache.org/viewvc?rev=419522&view=rev >> Log: >> Applied changes for "[#HARMONY-782] [classlib][nio]Relayout NIO test >> cases to platform dependent". >> >> Added: >> >> incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/common/ >> >> >> incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/common/org/ >> >> - copied from r419518, >> incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/org/ >> >> incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/linux/ >> >> >> incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/windows/ >> >> Removed: >> >> incubator/harmony/enhanced/classlib/trunk/modules/nio/src/test/java/org/ >> Modified: >> incubator/harmony/enhanced/classlib/trunk/modules/nio/.classpath >> incubator/harmony/enhanced/classlib/trunk/modules/nio/build.xml >> >> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/hyproperties.xml >> >> >> Modified: >> incubator/harmony/enhanced/classlib/trunk/modules/nio/.classpath >> URL: >> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/nio/.classpath?rev=419522&r1=419521&r2=419522&view=diff >> >> ============================================================================== >> >> --- incubator/harmony/enhanced/classlib/trunk/modules/nio/.classpath >> (original) >> +++ incubator/harmony/enhanced/classlib/trunk/modules/nio/.classpath >> Thu Jul 6 04:20:27 2006 >> @@ -1,7 +1,9 @@ >> >> >> >> - >> + > path="src/test/java/common"/> >> + > path="src/test/java/windows"/> >> + > path="src/test/java/linux"/> >> > path="src/test/resources"/> >> > path="org.eclipse.pde.core.requiredPlugins"/> >> > kind="var" path="JUNIT_HOME/junit.jar"/> >> >> Modified: >> incubator/harmony/enhanced/classlib/trunk/modules/nio/build.xml >> URL: >> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/nio/build.xml?rev=419522&r1=419521&r2=419522&view=diff >> >> ============================================================================== >> >> --- incubator/harmony/enhanced/classlib/trunk/modules/nio/build.xml >> (original) >> +++ incubator/harmony/enhanced/classlib/trunk/modules/nio/build.xml >> Thu Jul 6 04:20:27 2006 >> @@ -35,6 +35,9 @@ >> use the Eclipse Java compiler. --> >> >> >> + > + value="${hy.nio.src.test.java}/../${hy.os}" /> >> + >> >> >> >> @@ -108,19 +111,23 @@ >> >> >> >> - > - destdir="${hy.nio.bin.test}" >> - sourcepath="" >> - source="${hy.javac.source}" >> - target="${hy.javac.target}" >> - debug="${hy.javac.debug}"> >> - >> - >> - >> - >> - >> - >> - >> + > + sourcepath="" >> + source="${hy.javac.source}" >> + target="${hy.javac.target}" >> + debug="${hy.javac.debug}"> >> + >> + >> + > location="${hy.nio.src.test.java}"/> >> + > + >> location="${hy.nio.src.test.java.platform}"/> >> + >> + >> + >> + >> + >> + >> + >> >> >> >> @@ -153,6 +160,9 @@ >> >> > haltonfailure="no" unless="test.case"> >> >> + >> + >> + >> >> >> >> >> Modified: >> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/hyproperties.xml >> >> URL: >> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/nio/make/hyproperties.xml?rev=419522&r1=419521&r2=419522&view=diff >> >> ============================================================================== >> >> --- >> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/hyproperties.xml >> (original) >> +++ >> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/hyproperties.xml >> Thu Jul 6 04:20:27 2006 >> @@ -20,11 +20,11 @@ >> >>
>> >> - >> - >> + >> + >>
>> >> - >> + >> >> >> >> >> >> >> > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > -- Paulex Yang China Software Development Lab IBM --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org