Return-Path: 
 <harmony-dev-return-10066-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org
Received: (qmail 19039 invoked from network); 11 Jul 2006 12:57:35 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 11 Jul 2006 12:57:35 -0000
Received: (qmail 65969 invoked by uid 500); 11 Jul 2006 12:57:27 -0000
Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org
Received: (qmail 65926 invoked by uid 500); 11 Jul 2006 12:57:27 -0000
Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:harmony-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:harmony-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:harmony-dev@incubator.apache.org>
List-Id: <harmony-dev.incubator.apache.org>
Reply-To: harmony-dev@incubator.apache.org
Delivered-To: mailing list harmony-dev@incubator.apache.org
Received: (qmail 65910 invoked by uid 99); 11 Jul 2006 12:57:27 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2006 05:57:27 -0700
X-ASF-Spam-Status: No, hits=1.4 required=10.0
	tests=SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: 195.212.29.138 is neither permitted nor
 denied by domain of mark.hindess@googlemail.com)
Received: from [195.212.29.138] (HELO mtagate5.uk.ibm.com) (195.212.29.138)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2006 05:57:26 -0700
Received: from d06nrmr1407.portsmouth.uk.ibm.com
 (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185])
	by mtagate5.uk.ibm.com (8.13.6/8.13.6) with ESMTP id k6BCv2i6077510
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL)
	for <harmony-dev@incubator.apache.org>; Tue, 11 Jul 2006 12:57:04 GMT
Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com
 [9.149.37.228])
	by d06nrmr1407.portsmouth.uk.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id
 k6BCwUI2019348
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <harmony-dev@incubator.apache.org>; Tue, 11 Jul 2006 13:58:32 +0100
Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
 k6BCuum4020330
	for <harmony-dev@incubator.apache.org>; Tue, 11 Jul 2006 13:56:56 +0100
Received: from anaheim.local (sig-9-145-10-133.uk.ibm.com [9.145.10.133])
	by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
 k6BCuuIp020322
	for <harmony-dev@incubator.apache.org>; Tue, 11 Jul 2006 13:56:56 +0100
Message-Id: <200607111256.k6BCuuIp020322@d06av02.portsmouth.uk.ibm.com>
X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-7) with nmh-1.1
From: Mark Hindess <mark.hindess@googlemail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [classlib] debug compilation as default 
In-reply-to: Your message of "Tue, 11 Jul 2006 16:42:04 +0400."
             <12385bbd0607110542x7406b973xfee73440189557ae@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Tue, 11 Jul 2006 13:56:56 +0100
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N


On 11 July 2006 at 16:42, "Ivan Volosyuk" <ivan.volosyuk@gmail.com> wrote:
>
> [snip]
>
> Working on it. Not sure I like the way make is called from ant build.
> Here is an example:
> 
> (from modules/luni/build.xml)
> 
>     <target name="clean.native" if="is.windows">
>         <exec failonerror="true"
>               executable="${make.command}"
>               dir="${hy.luni.src.main.native}/vmi/${hy.os}">
>             <env key="HY_HDK" value="${hy.hdk}" />
>                     <arg line="clean" />
>         </exec>
>         <exec failonerror="true"
>               executable="${make.command}"
>               dir="${hy.luni.src.main.native}/luni/${hy.os}">
>             <env key="HY_HDK" value="${hy.hdk}" />
>                     <arg line="clean" />
>         </exec>
>                 <exec failonerror="true"
>               executable="${make.command}"
>               dir="${hy.luni.src.main.native}/launcher/${hy.os}">
>             <env key="HY_HDK" value="${hy.hdk}" />
>                     <arg line="clean" />
>         </exec>
>         <exec failonerror="true"
>               executable="${make.command}"
>               dir="${hy.luni.src.main.native}/vmls/${hy.os}">
>             <env key="HY_HDK" value="${hy.hdk}" />
>                     <arg line="clean" />
>         </exec>
>     </target>
> 
> This means that I should copy paste the environment variable from ant
> variable conversion code in dozen of places. BTW, why the clean up is
> just windows specific? What about Linux?

Good question.  I look forward to Oliver's answer. ;-)

> I'm going to create some kind of macro command which will include all
> common settings for make execution. (/me is reading manuals)

Excellent idea.  Something like (untested):

  <make dir="${hy.luni.src.main.native}/vmls/${hy.os}" target="clean" />

and:

  <macrodef name="make">
    <attribute name="dir" />
    <attribute name="target" default="" />
    <sequential>
      <exec failonerror="true"
            executable="${make.command}"
            dir="@{dir}">
        <env key="HY_HDK" value="${hy.hdk}" />
        <arg line="@{target}" />
      </exec>
    <sequential>
  </macrodef>

(You might have to make the default for target "all".)

At the moment the only common file you could put this in is
properties.xml which isn't elegant but it might be okay for now.  We
really need to have a common file that gets moved to the deploy tree -
like the make fragments.

Regards,
 Mark.



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org