From harmony-dev-return-9768-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org Thu Jul 06 06:57:47 2006 Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 71433 invoked from network); 6 Jul 2006 06:57:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Jul 2006 06:57:46 -0000 Received: (qmail 62759 invoked by uid 500); 6 Jul 2006 06:57:43 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 62544 invoked by uid 500); 6 Jul 2006 06:57:42 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 62533 invoked by uid 99); 6 Jul 2006 06:57:42 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2006 23:57:42 -0700 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 195.212.29.136 is neither permitted nor denied by domain of mark.hindess@googlemail.com) Received: from [195.212.29.136] (HELO mtagate3.uk.ibm.com) (195.212.29.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2006 23:57:42 -0700 Received: from d06nrmr1407.portsmouth.uk.ibm.com (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185]) by mtagate3.uk.ibm.com (8.13.6/8.13.6) with ESMTP id k666vKW6109080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Thu, 6 Jul 2006 07:57:20 +0100 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id k666wmtf138880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 6 Jul 2006 07:58:48 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k666vKMB019461 for ; Thu, 6 Jul 2006 07:57:20 +0100 Received: from anaheim.local (sig-9-145-14-195.uk.ibm.com [9.145.14.195]) by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k666vJRe019455; Thu, 6 Jul 2006 07:57:20 +0100 Message-Id: <200607060657.k666vJRe019455@d06av02.portsmouth.uk.ibm.com> X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-7) with nmh-1.1 From: Mark Hindess To: harmony-dev@incubator.apache.org, geir@pobox.com Subject: Re: svn commit: r418195 - /incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java In-reply-to: Your message of "Wed, 05 Jul 2006 10:06:51 EDT." <44ABC77B.2040502@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 06 Jul 2006 07:57:19 +0100 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 5 July 2006 at 10:06, Geir Magnusson Jr wrote: > > Mark Hindess wrote: > > > > Sorry to interrupt your game, > > "Umpire, can you get this streaker off the court, please?" > > :) :-) > > but is there any reason why the jar must have the version number in > > the name - it's in the MANIFEST after all. Couldn't we just copy it > > to deploy/jdk/lib/ecj.jar? > > > > After all, we don't put a version number in the names of any other > > jars? > > And I've always found that to be a nightmare when trying to sort out > what is what. It's so much easier to just look at the filename. > > I think the filename should be irrelevant, btw, hence the proposal for > the services idea. I wonder what users expect? For instance, people are used to tools.jar not tools-1.0.jar. Having a consistent name makes it easier for people to point to it. (The truth comes out ... ) I guess the reason I mention this is that I was try to set up an ant script to use the ecj.jar from the Harmony JDK and it was simpler to write the script to point to ecj.jar than to have to locate ecj-*.jar. Regards, Mark. > > (We'd still want to allow the user to override the location.) > > > > Regards, > > Mark. > > > > On 4 July 2006 at 8:52, Geir Magnusson Jr wrote: > >> Actually, what about some kind of SPI? Or now that JSR-199 in in public > >> draft form, anything useful in there? > >> > >> (There's two more questions.... 40-love) > >> > >> geir > >> > >> > >> Geir Magnusson Jr wrote: > >>> Tim Ellison wrote: > >>>> Geir Magnusson Jr wrote: > >>>>> Can you get your IDE to invoke ant? > >>>> Of course, but do you really want our implementation code to be closely > >>>> coupled to Ant? > >>> RIght now it's coupled to a specific version number from eclipse-land > >>> that requires the code itself to change when they update. > >>> > >>>> (please answer with a question, I'm getting into the Wimbledon spirit) > >>> Maybe we could use a property? > >>> > >>> :) > >>> > >>> geir > >>> > >>>> Regards, > >>>> Tim > >>>> > >>>>> Tim Ellison wrote: > >>>>>> Geir Magnusson Jr wrote: > >>>>>>> Indeed not. Should we just use an ant filter and a property to set th > is > >> ? > >>>>>> Does your IDE cope with this? It will require testing exclusively via > >>>>>> Ant I think. > >>>>>> > >>>>>> Regards, > >>>>>> Tim > >>>>>> > >>>>>>> geir > >>>>>>> > >>>>>>> > >>>>>>> tellison@apache.org wrote: > >>>>>>>> Author: tellison > >>>>>>>> Date: Fri Jun 30 00:49:45 2006 > >>>>>>>> New Revision: 418195 > >>>>>>>> > >>>>>>>> URL: http://svn.apache.org/viewvc?rev=418195&view=rev > >>>>>>>> Log: > >>>>>>>> Update compiler impl reference > >>>>>>>> (should not be hardcoded like this) > >>>>>>>> > >>>>>>>> Modified: > >>>>>>>> incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main > /j > >> ava/org/apache/harmony/tools/javac/Compiler.java > >>>>>>>> Modified: incubator/harmony/enhanced/classlib/trunk/modules/tools/sr > c/ > >> main/java/org/apache/harmony/tools/javac/Compiler.java > >>>>>>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classli > b/ > >> trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler. > jav > >> a?rev=418195&r1=418194&r2=418195&view=diff > >>>>>>>> ==================================================================== > == > >> ======== > >>>>>>>> --- incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main > /j > >> ava/org/apache/harmony/tools/javac/Compiler.java (original) > >>>>>>>> +++ incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main > /j > >> ava/org/apache/harmony/tools/javac/Compiler.java Fri Jun 30 00:49:45 2006 > >>>>>>>> @@ -36,7 +36,7 @@ > >>>>>>>> "ISO8859_1"); > >>>>>>>> > >>>>>>>> /* FIXME: Hard-coded for now, the name of the ECJ JAR file */ > >>>>>>>> - static final String ECJ_JAR_FILE = "ecj_3.2RC5.jar"; > >>>>>>>> + static final String ECJ_JAR_FILE = "ecj_3.2MAINT.jar"; > >>>>>>>> > >>>>>>>> /* The name of the ECJ compiler class */ > >>>>>>>> static final String MAIN_CLASS_NAME = "org.eclipse.jdt.internal > .c > >> ompiler.batch.Main"; > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>> --------------------------------------------------------------------- > >>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html > >>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >>>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.or > g > >>>>>>> > >>>>>>> > >>>>> --------------------------------------------------------------------- > >>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html > >>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org > >>>>> > >>>>> > >>> --------------------------------------------------------------------- > >>> Terms of use : http://incubator.apache.org/harmony/mailing.html > >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org > >>> > >>> > >>> > >> --------------------------------------------------------------------- > >> Terms of use : http://incubator.apache.org/harmony/mailing.html > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org