harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Loenko" <mloe...@gmail.com>
Subject Re: [classlib][testing] question about org.apache.harmony.tests.java.nio.channels.SocketChannelTest
Date Sun, 02 Jul 2006 07:17:32 GMT
2006/6/30, Andrew Zhang <zhanghuangzhu@gmail.com>:
> Hello Mikhail,
>
> Totally agree with you. assertEquals doesn't make any sense here.
>
> I will remove these useless assertEquals in NIO module tests.

Great!



>
> Thanks!
>
>
> On 6/30/06, Mikhail Loenko <mloenko@gmail.com> wrote:
> >
> > It is not clear why we have assertEquals in this type of constructions
> >
> >        try {
> >            assertEquals(CAPACITY_NORMAL, this.channel1.read(buf));
> >            fail("Should throw ClosedChannelException");
> >        } catch (ClosedChannelException e) {
> >            // correct
> >        }
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Andrew Zhang
> China Software Development Lab, IBM
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message