harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang" <zhanghuang...@gmail.com>
Subject Re: [classlib] trying new framework for testing serialization
Date Wed, 05 Jul 2006 08:15:21 GMT
Hello Stepan,

Thanks for your explanation.

It seems I have to wait until NIO test package layout is complete.
The test package structure is not the same as SerializationTest framework
expects.
I'll use merged serialization test framework then. :)

btw: Paulex said he'd like to do it in the previous thread.

Thanks.



On 7/5/06, Stepan Mishura <stepan.mishura@gmail.com> wrote:
>
> Hi Andrew,
>
> On 7/3/06, Andrew Zhang wrote:
> >
> > Hi Stepan,
> >
> > I tried serialization test framework, and found it's really easy to use.
> > :)
> >
> > Here I have a small question: why TestCase is designed as first
> parameter?
>
>
> Because it is required for all methods for testing compatibility so I made
> it as first parameter.
>
> > If I understand correctly, it's used to parse exception name.
>
> No, it is not. It is used to locate resource files only. For example,
> TestCase:
>   org.apache.harmony.luni.tests.java.lang.SomeClassTest
> Resource:
>   org/apache/harmony/luni/tests/java/lang/SomeClassTest.golden.ser
>
> So is it the
> > same  if we simply pass the String or Class of the object to
> > SerializationTest?
>
>
> Do you mean Class of TestCase or an object to be tested?
>
> Maybe it's a tradeoff for highly automated, still I think pass String or
> > Class is not a big deal for user.
> >
> > Did I miss something? Or TestCase is used for other reasons?
>
>
> It is used to locate resource files only.
>
> Thanks,
> Stepan.
>
> >
> >
> >
> >
> > On 6/30/06, Stepan Mishura wrote:
> > >
> > > On 6/30/06, Jimmy, Jing Lv wrote:
> > > >
> > > > Stepan Mishura wrote:
> > > > > Hi Jimmy,
> > > > >
> > > > <SNIP>
> > > > > 3. The test needs ser-files, so it may be necessary to add a
> method
> > to
> > > > >> create this file easily just like the old framework. I find a
> > > protected
> > > > >> method produceGoldenFiles(), is that used for it (why
> protected?)?
> > > This
> > > > >> may be necessary to guildance.
> > > > >> What's more, the ser-file must be end with ".ser", but in new
> > > > framework,
> > > > >> I still find it uses ".dat" . And the path is
> > "test/common/unit/..."
> > > > but
> > > > >> in Harmony's Test Guildance
> > > > tells:"/src/test/resources/serialization..."
> > > > >
> > > > >
> > > > > Yes, I agree that utility method for producing golden files will
> be
> > > > useful.
> > > > > I didn't think how to implement it yet - so suggestion and patches
> > are
> > > > > welcome.
> > > > >
> > > >
> > > > I see now, thank you very much Stepan! :)
> > > > To produce golden files,  I believe a little change to
> > > > produceGoldenFiles() may meet this requirement. I'd like to help.:)
> > >
> > >
> > > Great!
> > >
> > > But first of all it may change its search path, as when I create a new
> > > > test and try verifyGolden(), I find a FileNotFoundException. It
> seems
> > > > trying to search "test/common/unit/.../SomeTest.golden.dat", is that
> > > > because of serialization-test for security? Waiting for your
> > refactoring
> > > > :)
> > > >
> > > >
> > > >
> > > > Currently the framework search resource files in the next order:
> > > it tries to load a resource file from the classpath (resource file
> name
> > > should follow new conventions); if it failed then it loads it in 'old'
> > way
> > > (
> > > i.e. using RESOURCE_DIR system property). The 'old' way will be
> removed
> > > after completing 'security' tests migration.
> > >
> > > If you see FileNotFoundException then it means that the framework can
> > find
> > > resource file on the classpath. Please check that:
> > > 1) a resource file follows new naming conventions
> > > 2) a resource file is on the classpath
> > >
> > > BTW, I've refactored one security test[1]. You may wish to use it as
> > > example.
> > >
> > > Thanks,
> > > Stepan Mishura
> > >
> > > P.S.
> > > I'll have random access to e-mail starting next week. Please expect
> some
> > > delay in response.
> > >
> > > [1]
> > >
> > >
> >
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/serialization/KeyPairTest.java?revision=418191&view=markup
> > >
> > > ------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Andrew Zhang
> > China Software Development Lab, IBM
> >
> >
>
>
> --
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
>
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Andrew Zhang
China Software Development Lab, IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message