harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: Stack Overflow Error support issues
Date Fri, 21 Jul 2006 20:06:07 GMT
I'll commit as is - if you need to modify  the stack space issue, just
submit a new patch

geir

Rana Dasgupta wrote:
> Pavel,
>   I tried the attached overflow test, and then applied the patch and
> retried it. The patch looks good. A couple of comments:
> 
>   - I could not get the  unwind failure that you have mentioned (with
>   the overflow happening in the first two lines) though I played around
> with
>   the test, but that may depend on what the specific setup of the stack
> is at
>   that point?
>   - I noticed that on both Linux and Windows you preload the SOE class
>   and precompile it. This may be OK.
>   - But I also saw that you fail the JIT if you don't have 256 K of free
>   stack space. The default Windows stack size is only 1 MB. Do we need
> to fail
>   a compile of 10 lines of bytecode if we don't have 1/4 of the stack
>   available? Maybe this can be less strict, or some heuristic based on
> method
>   size? What do you think  about this?
> 
> 
>   It would be nice if this patch could get committed, it is a good solution
> for exceptions in Java code. For native code frames, we can continue the
> work needed on top of this fix.
> 
> Thanks,
> Rana
> 
> On 7/21/06, Pavel Afremov <pavel.n.afremov@gmail.com> wrote:
> 
>> Because more elegant decision wasn't proposed during current discussion,
>> I'd
>> like to put the patch with results of my experiments into JIRA, as Stack
>> Overflow Implementation.
>>
>> You can find it in
>> *HARMONY-945*<https://issues.apache.org/jira/browse/HARMONY-945>.
>> Welcome to try it.
>>
>> Pavel Afremov.
>>
>>
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message