harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: [classlib][logging] Test Failures - FileHandlerTest (was Re: [bild] linux failure)
Date Tue, 18 Jul 2006 11:24:19 GMT
Heh.  We have to share...

Nathan Beyer wrote:
> Since this "did" pass tests on the Windows platform, does that mean I only
> owe half-a-beer to everyone?
> 
> -Nathan
> 
> 
>> -----Original Message-----
>> From: Geir Magnusson Jr [mailto:geir@pobox.com]
>> Sent: Monday, July 17, 2006 12:29 PM
>> To: harmony-dev@incubator.apache.org
>> Subject: [classlib][logging] Test Failures - FileHandlerTest (was Re:
>> [bild] linux failure)
>>
>> Ok, the problem is that we're including FileHandlerTest, there are a few
>> bugs (maybe) and our implementation differs from the RI, and the failure
>> is platform dependent to boot.
>>
>> First bug, in FileHandlerTest.testInvalidParams() we have things like :
>>
>>    // %t and %p parsing can add file separate automatically
>>    FileHandler hl = new FileHandler("%taaa");
>>
>> First problem is that our implemention *doesn't* add the separator, so
>> the result is that logging is trying to create (on linux)
>>
>>     /tmpaaa
>>
>> and given that my root dir is locked down (and I don't run as root!),
>> creating that file failed.   On my windows box, this passed because
>> java.io.tmpdir ends w/ a separator, so it creates the thing as expected.
>>
>> Now, the RI on linux puts in the separator, so the result is
>>
>>   /tmp/aaa
>>
>> Reading the spec, this is not what I expected, as there is a separator
>> "/" defined, and all examples use it, and nothing is said about it.
>>
>> So, we can either fix the test, or given that the RI does behave beyond
>> the spec (and adds the separator), I suppose that we should just simply
>> add a separator in the implementation for %t and %h?
>>
>> geir
>>
>>
>> Geir Magnusson Jr wrote:
>>> Ok, I understand why.  I'll either fix, or post an item for discussion
>>> re the fix.
>>>
>>> I think Nathan owes us a beer.
>>>
>>> geir
>>>
>>>
>>> Tim Ellison wrote:
>>>> Sorry, yes I meant the test run.
>>>>
>>>> Regards,
>>>> Tim
>>>>
>>>> Geir Magnusson Jr wrote:
>>>>> Oh, I can build, but tests don't pass.
>>>>>
>>>>> geir
>>>>>
>>>>> Vladimir Gorr wrote:
>>>>>> I was able to successfully build on Linux for the recent sources.
>>>>>>
>>>>>> Thanks,
>>>>>> Vladimir.
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 7/17/06, Tim Ellison <t.p.ellison@gmail.com> wrote:
>>>>>>> The linux build is failing as follows, I have not investigated:
>>>>>>>
>>>>>>> java.io.FileNotFoundException at
>>>>>>>
>> org.apache.harmony.luni.platform.OSFileSystem.open(OSFileSystem.java:223)
>>>>>>> at java.io.FileOutputStream.<init>(FileOutputStream.java:92)
at
>>>>>>> java.io.FileOutputStream.<init>(FileOutputStream.java:155)
at
>>>>>>> java.util.logging.FileHandler.initOutputFiles(FileHandler.java:207)
>> at
>>>>>>> java.util.logging.FileHandler.init(FileHandler.java:190) at
>>>>>>> java.util.logging.FileHandler.<init>(FileHandler.java:386)
at
>>>>>>>
>>>>>>>
>> org.apache.harmony.logging.tests.java.util.logging.FileHandlerTest.testInv
>> alidParams
>>>>>>> (FileHandlerTest.java:453)
>>>>>>> at
>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Tim Ellison (t.p.ellison@gmail.com)
>>>>>>> IBM Java technology centre, UK.
>>>>>>>
>>>>>>> --------------------------------------------------------------------
>> -
>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>>> For additional commands, e-mail: harmony-dev-
>> help@incubator.apache.org
>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>
>>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message