harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: [classlib] debug compilation as default
Date Mon, 17 Jul 2006 12:11:39 GMT


Salikh Zakirov wrote:
>> Ivan Volosyuk wrote:
>>> I have already implemented it using ant variables, look at the latest
>>> patch. You can use following notation with it:
>>>  ant -Dhy.cfg=release
> 
> Geir Magnusson Jr wrote:
>> Now we're getting somewhere.
>>
>> I assume then I can put this into the build.properties that we'll be
>> adding Real Soon Now (as I can never remember command line args anyway...)
> 
> Please, please, do *not* introduce any more build.properties files.

We need *one*.  right now, things are in environment variables, embedded
in build.xml files, or randomly passed on the command line.  It's ad-hoc
and not easily reproducible or portable.

> 
> The files that may need to be customized to get specific build configuration
> should never be version-controlled. Besides, keeping configuration files
> in the workspace means you cannot make your configuration permanent.
> I see the properties files as anti-usable.

The default set is version controlled.  It's not called
build.properties.  The properties in build.properties override the defaults.


> 
> The main point of using environment variables instead of ant properties
> is an ability to do a *workstation-specific* configuration in a permanent way,
> so that I do not need to do any configuration steps before the build for
> the fresh workspace, once I have configured my environment.

I disagree.  you can use the properties to do things in a workstation
specific way, and in a very clean, localized way.  One file, rather than
 in semi-visible and distributed bits.

You can also come up with configuration sets, that can be checked in and
re-used in a predictable manner.

test_local_debug.properties
test_remote_debug.properties
test_local_release.properties
test_remote_release.propertes

etc

You can also cleanly, portably automate things too.

> 
> And by the way, the solution to run 'HY_CFG=xyz ant' with 
> corresponding 
>     <property environment="env"/>
>     <condition property='hy.cfg' value='${env.HY_CFG}'>
>        <isset property="env.HY_CFG"/>
>     </condition>
> worked perfectly for the DRLVM builds on Windows. What's more,
> it is *compatible* with 'ant -Dhy.cfg=...' syntax. 
> 
> I have not heard any specific concerns why this can't be used.

It can be used.  I'm just proposing something portable and reusable.

geir


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message