harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From George Harley <george.c.har...@googlemail.com>
Subject Re: [classlib] HARMONY-88 misses source file for MockJavaBean2.class
Date Thu, 13 Jul 2006 09:39:05 GMT
Mikhail Loenko wrote:
> Hi George
>
> I did not know that. When I run "ant test -Dtest.jre.home=..." for some
> odd reason this test does not run at all. I'll try to figure out why.
>
> I completely agree that the test should pass on RI. I'll fix the test.
>
> The old version of the test copied files on the disk in many test 
> methods.
> The new version does not, so it should be at least faster. Please let
> me know if for some reason you don't like "custom classloader" version
>
> Thanks,
> Mikhail

Hi Mikhail,

Thanks for looking into the matter of running the tests on the RI. That 
was my only concern really. Your alternative version of the test looks 
great to me.

Best regards,
George

>
> 2006/7/13, Geir Magnusson Jr <geir@pobox.com>:
>>
>>
>> George Harley wrote:
>> > Hi Mikhail,
>> >
>> > You are probably already aware of this but the tests that use the
>> > SerClassLoader custom class loader result in a StackOverflowError when
>> > run against the RI. The overridden implementation of
>> > findResource(String) calls getResource(String) which, according to the
>> > spec, may end up calling into findResource(String) and so on...
>> >
>> > Fixing up the original version of the BeanTest class (i.e. before
>> > revision 421204) is quite straightforward really. I'm happy to 
>> check it
>> > in but if you want to go with a custom class loader approach then 
>> that's
>> > equally fine IMHO. I just think that it would be nice though if the
>> > tests could be run on both Harmony and the RI.
>>
>> +1
>>
>> >
>> > What do you think ?
>> >
>> > Best regards,
>> > George
>> >
>> >
>> >
>> > Mikhail Loenko wrote:
>> >> Hi George!
>> >>
>> >> HARMONY-88 contribution contains a file "MockJavaBean2.bin"
>> >> that seems to be a binary representation of
>> >> "tests.api.java.beans.mock.MockJavaBean2" class
>> >>
>> >> in r406595 you have modifed BeansTest.java, for example
>> >>
>> >> Beans.instantiate(loader,"tests.api.java.beans.mock.MockJavaBean2");
>> >>
>> >> was replaced with
>> >>
>> >> 
>> Beans.instantiate(loader,"org.apache.harmony.beans.tests.java.beans.mock.MockJavaBean2");

>>
>> >>
>> >>
>> >> So that ClassNotFoundException is now thrown.
>> >>
>> >> Could you please provide sources for MockJavaBean2 so that the 
>> failure
>> >> could be fixed?
>> >>
>> >> Thanks,
>> >> Mikhail
>> >>
>> >> ---------------------------------------------------------------------
>> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> >> For additional commands, e-mail: 
>> harmony-dev-help@incubator.apache.org
>> >>
>> >>
>> >
>> >
>> > ---------------------------------------------------------------------
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>> >
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message