harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: svn commit: r418195 - /incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java
Date Wed, 05 Jul 2006 14:06:51 GMT


Mark Hindess wrote:
> Sorry to interrupt your game,

"Umpire, can you get this streaker off the court, please?"

:)

> but is there any reason why the jar must
> have the version number in the name - it's in the MANIFEST after all.
> Couldn't we just copy it to deploy/jdk/lib/ecj.jar?
> 
> After all, we don't put a version number in the names of any other jars?

And I've always found that to be a nightmare when trying to sort out
what is what.  It's so much easier to just look at the filename.

I think the filename should be irrelevant, btw, hence the proposal for
the services idea.

> 
> (We'd still want to allow the user to override the location.)
> 
> Regards,
>  Mark.
> 
> On 4 July 2006 at 8:52, Geir Magnusson Jr <geir@pobox.com> wrote:
>> Actually, what about some kind of SPI?  Or now that JSR-199 in in public
>> draft form, anything useful in there?
>>
>> (There's two more questions....  40-love)
>>
>> geir
>>
>>
>> Geir Magnusson Jr wrote:
>>> Tim Ellison wrote:
>>>> Geir Magnusson Jr wrote:
>>>>> Can you get your IDE to invoke ant?
>>>> Of course, but do you really want our implementation code to be closely
>>>> coupled to Ant?
>>> RIght now it's coupled to a specific version number from eclipse-land
>>> that requires the code itself to change when they update.
>>>
>>>> (please answer with a question, I'm getting into the Wimbledon spirit)
>>> Maybe we could use a property?
>>>
>>> :)
>>>
>>> geir
>>>
>>>> Regards,
>>>> Tim
>>>>
>>>>> Tim Ellison wrote:
>>>>>> Geir Magnusson Jr wrote:
>>>>>>> Indeed not. Should we just use an ant filter and a property to
set this
>> ?
>>>>>> Does your IDE cope with this?  It will require testing exclusively
via
>>>>>> Ant I think.
>>>>>>
>>>>>> Regards,
>>>>>> Tim
>>>>>>
>>>>>>> geir
>>>>>>>
>>>>>>>
>>>>>>> tellison@apache.org wrote:
>>>>>>>> Author: tellison
>>>>>>>> Date: Fri Jun 30 00:49:45 2006
>>>>>>>> New Revision: 418195
>>>>>>>>
>>>>>>>> URL: http://svn.apache.org/viewvc?rev=418195&view=rev
>>>>>>>> Log:
>>>>>>>> Update compiler impl reference
>>>>>>>> (should not be hardcoded like this)
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>>     incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/j
>> ava/org/apache/harmony/tools/javac/Compiler.java
>>>>>>>> Modified: incubator/harmony/enhanced/classlib/trunk/modules/tools/src/
>> main/java/org/apache/harmony/tools/javac/Compiler.java
>>>>>>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/
>> trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.jav
>> a?rev=418195&r1=418194&r2=418195&view=diff
>>>>>>>> ======================================================================
>> ========
>>>>>>>> --- incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/j
>> ava/org/apache/harmony/tools/javac/Compiler.java (original)
>>>>>>>> +++ incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/j
>> ava/org/apache/harmony/tools/javac/Compiler.java Fri Jun 30 00:49:45 2006
>>>>>>>> @@ -36,7 +36,7 @@
>>>>>>>>              "ISO8859_1");
>>>>>>>>  
>>>>>>>>      /* FIXME: Hard-coded for now, the name of the ECJ JAR
file */
>>>>>>>> -    static final String ECJ_JAR_FILE = "ecj_3.2RC5.jar";
>>>>>>>> +    static final String ECJ_JAR_FILE = "ecj_3.2MAINT.jar";
>>>>>>>>  
>>>>>>>>      /* The name of the ECJ compiler class */
>>>>>>>>      static final String MAIN_CLASS_NAME = "org.eclipse.jdt.internal.c
>> ompiler.batch.Main";
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>>>
>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>
>>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message