Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of anton.luht@gmail.com designates
 66.249.92.174 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ZzSHnYRPR1XAY4jxBD2SKcDEiHXPcQzbnKCdGYMCsivfrVnyDiFBwVAkFPeKG7jx0EStTgt0CVF0ixTSJfJ/Ud/XJR0T79PzbL/FQJIxYge4QbWlib0cTwP8f9v5l0z11VMBVeAn5J5ZQtYd56CEq0sBEOMNKVyGtRTHuu3QVjQ=
Message-ID: <ddda44ee0606230809r6116594ds115e41091ebaac1f@mail.gmail.com>
Date: Fri, 23 Jun 2006 19:09:15 +0400
From: "Anton Luht" <anton.luht@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Fwd: [jira] Created: (HARMONY-652) Remove code duplicates
In-Reply-To: <20832075.1151073510664.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20832075.1151073510664.JavaMail.jira@brutus>

Good day,

PMD [1] has found lots of code duplicates in Harmony codebase. Of
course this is not a big problem but something that is a good
candidate for refactoring. The worst thing in copy-paste is that when
one of the copies modified (enhancement, bug fix, etc), others remain
unchanged which causes annoying deja vu bugs.

PMD also can find different kind of problems in code [2], for example
- empty try, catch, finally, synchronized blocks
- missing super...() calls where appropriate
- sun.* imports
- reassigning values to parameters

Maybe it's worth to select a set of rules that seem useful and check
code from time to time. Maybe it's worth to use not PMD but another
static analyzer.

[1] http://pmd.sourceforge.net/
[2] http://pmd.sourceforge.net/rules/index.html


-- 
Regards,
Anton Luht,
Intel Middleware Products Division

---------- Forwarded message ----------
From: Anton Luht (JIRA) <jira@apache.org>
Date: Jun 23, 2006 6:38 PM
Subject: [jira] Created: (HARMONY-652) Remove code duplicates

Remove code duplicates
-----------------------

        Key: HARMONY-652
        URL: http://issues.apache.org/jira/browse/HARMONY-652
    Project: Harmony
       Type: Improvement

Components: VM, Classlib
   Reporter: Anton Luht
   Priority: Minor
Attachments: pmd_results_nodupfiles.tgz

Checking source code of Harmony (rev. 416328) using Copy/Paste
detector included in PMD [1] revealed that some blocks of code are
copy-pasted. Most of copy-paste issues were found in tests.

I've searched copy-paste insde each module, not trying to find out if
there are similar pieces of code across modules.

The results of the scan are attached.

[1] http://pmd.sourceforge.net/

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
  http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
  http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org