Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of mloenko@gmail.com designates
 66.249.92.174 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ljEDlt+U4hsMNBp1xoKqLFTdNxwf/Hlnovou/aSw2VpXwCiSv3Wy2pA1dfOzMc1i0vU19Jmdp0JoRRF4QVVCgIheqtkZFvqAzXxW3eJMl12hTzCDwmrrvDbPUXQGhsk03vBn5x68hLiyXRLEZLhdaBanfrhVPq/5nLe7MsYsUqA=
Message-ID: <906dd82e0606061952l6c4a6abdwbd89357c18fdd964@mail.gmail.com>
Date: Wed, 7 Jun 2006 09:52:41 +0700
From: "Mikhail Loenko" <mloenko@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [classlib] [testing] 37% of total test execution time is spent in
 a single test
In-Reply-To: <1149790354.6801.4.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <906dd82e0606010723h4eda0645v378bbd2bfc24bad7@mail.gmail.com>
	 <447EFDD0.1050600@pobox.com>
	 <906dd82e0606010815n443829dbwe7bc6ef39bb14cc5@mail.gmail.com>
	 <447F0550.4000708@pobox.com>
	 <906dd82e0606010826h1ce31b7ap6e310b96a0103cc0@mail.gmail.com>
	 <1149790354.6801.4.camel@localhost>

If that reason is detected in the OS, not in our code, why does it
make difference?

Do you mean that we should not just test our code but also make
sure it works well in any environment (including OS)? I'd buy that
but think in this case it is not a unit test and thus should be moved
to a separate suite.

Thanks,
Mikhail

2006/6/9, Santiago Gala <sgala@apache.org>:
> El jue, 01-06-2006 a las 22:26 +0700, Mikhail Loenko escribi=F3:
> > 2006/6/1, Geir Magnusson Jr <geir@pobox.com>:
> > >
> > >
> > > Mikhail Loenko wrote:
> > > > 2006/6/1, Geir Magnusson Jr <geir@pobox.com>:
> > > >>
> > > >> I don't quite grok what you mean - could you post what you are
> > > >> suggesting in code here on -dev?
> > > >
> > > >
> > > > Index: modules/luni/src/test/java/tests/api/java/net/Inet6AddressTe=
st.java
> > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > > ---
> > > > modules/luni/src/test/java/tests/api/java/net/Inet6AddressTest.java
> > > > (revision
> > > > 410480)
> > > > +++
> > > > modules/luni/src/test/java/tests/api/java/net/Inet6AddressTest.java
> > > > (working
> > > > copy)
> > > > @@ -785,7 +785,7 @@
> > > >                 "FFFF:FFFF:FFFF:FFFF:FFFF:FFFF:255.255.255.255",
> > > >                 "0:0:0:0:0:0:0:0", "0:0:0:0:0:0:0.0.0.0" };
> > > >
> > > > -        String invalidIPAddresses[] =3D { ":", "FFFF:FFFF", "1:1",
> > > > "::1.2.3.444" };
>
> Not the code author, but the last address is illegal for a different
> reason to the others, specifically because 444>255 and only because of
> this.
>
> Regards
> Santiago
>
> > > > +        String invalidIPAddresses[] =3D { "FFFF:FFFF" };
> > > >
> > > >         for (int i =3D 0; i < validIPAddresses.length; i++) {
> > > >
> > > >
> > >
> > > Thx - why do you want to remove testing the others?  Because you beli=
eve
> > > that it is in effect testing the resolver in the OS since each return=
s
> > > the same answer,and thus it's testing the same thing over and over?
> >
> > I believe so, but I'd like to hear confirmation from code authors
> >
> > Thanks,
> > Mikhail
> >
> >
> > >
> > > If so, I agree with you.
> > >
> > > If not, I still don't grok the point :)
> > >
> > > geir
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.or=
g
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> --
> VP and Chair, Apache Portals (http://portals.apache.org)
> Apache Software Foundation
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
>
> iD8DBQBEiGiRZAeG2a2/nhoRAhEQAKCh2XU75nmRtUY75I0faZu9a6/M4QCggaJX
> JayynGPTdwg8+3NAp1DnPKk=3D
> =3DZwHY
> -----END PGP SIGNATURE-----
>
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org