Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 89766 invoked from network); 7 Jun 2006 05:14:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Jun 2006 05:14:26 -0000 Received: (qmail 77233 invoked by uid 500); 7 Jun 2006 05:14:22 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 77046 invoked by uid 500); 7 Jun 2006 05:14:22 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 77035 invoked by uid 99); 7 Jun 2006 05:14:22 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2006 22:14:22 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of stepan.mishura@gmail.com designates 66.249.82.204 as permitted sender) Received: from [66.249.82.204] (HELO wx-out-0102.google.com) (66.249.82.204) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2006 22:14:21 -0700 Received: by wx-out-0102.google.com with SMTP id s6so70502wxc for ; Tue, 06 Jun 2006 22:14:00 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=Dlvb9uB5WXlivwvQ8SHEWM2Z81mm/tYo3pdacM4I6k4T2bbx7CGj8W/fPmmfQXZHlPavj0u39Cv4KqNiKT9YJFbsk+Pw5+SGaEcHuVV2qnjT5F8mO/srK/q7rnVjym9T9avTDqIIfrQTa1iiwwZk5cQODVkIhbyGDVTgNIFkluw= Received: by 10.70.62.9 with SMTP id k9mr244383wxa; Tue, 06 Jun 2006 22:14:00 -0700 (PDT) Received: by 10.70.6.15 with HTTP; Tue, 6 Jun 2006 22:14:00 -0700 (PDT) Message-ID: <6e47b64f0606062214s15f3d430h4df7f5d8cfef391c@mail.gmail.com> Date: Wed, 7 Jun 2006 12:14:00 +0700 From: "Stepan Mishura" To: harmony-dev@incubator.apache.org Subject: Re: [classlib] Enum ready to go In-Reply-To: <906dd82e0606062206w37e706f3i8bf4af332bbb9355@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_64411_1959344.1149657240486" References: <4485B59A.1090901@gmail.com> <4485C592.5020203@pobox.com> <906dd82e0606062206w37e706f3i8bf4af332bbb9355@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_64411_1959344.1149657240486 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Yes, both tests fail for me. Also tests.api.java.net.AuthenticatorTestfailed too. Thanks, Stepan. On 6/7/06, Mikhail Loenko wrote: > > I see two failing tests. Does anybody see them too? > org.apache.harmony.tests.java.lang.EnumTest > tests.api.java.net.ProxyTest > > Thanks, > Mikhail > > > 2006/6/7, Geir Magnusson Jr : > > cool! (I didn't remember you were working on it... excellent) > > > > Tim Ellison wrote: > > > Heads up that I completed the implementation of j.l.Enum today; so you > > > can go mad and use enum types in classlib code for real now. > > > > > > I wrote a bunch of tests but if you could hammer on it and try to > break > > > it that would be good :-) > > > > > > > > > If you take a look at the implementation [1] of valueOf(Class, String) > > > it uses reflection to get the enum constant values. I'm not sure how > > > 'popular' the valueOf() method is, but since the values don't change > > > they are a good candidate for being cached if it proves to be called > > > frequently. I'm happy to do that if people think it is worthwhile. > > > > > > Regards, > > > Tim > > > > > > > > > [1] > > > > http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/lang/Enum.java?revision=412166&view=markup > > > > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > -- Thanks, Stepan Mishura Intel Middleware Products Division ------------------------------------------------------ Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org ------=_Part_64411_1959344.1149657240486--