Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: neutral (asf.osuosl.org: 202.81.18.155 is neither permitted nor
 denied by domain of paulex.yang@gmail.com)
Message-ID: <449FA7B3.5020200@gmail.com>
Date: Mon, 26 Jun 2006 17:24:03 +0800
From: Paulex Yang <paulex.yang@gmail.com>
User-Agent: Thunderbird 1.5.0.4 (Windows/20060516)
MIME-Version: 1.0
To: harmony-dev@incubator.apache.org
Subject: Re: [classlib] mem
References: <449DC023.4030907@pobox.com> <449F9874.2000909@gmail.com>
 <449FA3AA.4080401@gmail.com>
In-Reply-To: <449FA3AA.4080401@gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1; format=flowed

Tim Ellison wrote:
> Jimmy, Jing Lv wrote:
>   
>> Geir Magnusson Jr wrote:
>>     
>>> Why would I use
>>>
>>> portLib->mem_allocate_memory(portLib....)
>>>
>>> over just calling
>>>
>>> hymem_allocate_memory(portlib, ....)
>>>
>>>       
>> Hi Geir:
>>
>>    Not sure if the later is "hymem_allocate_memory(int size)"? If so,
>> they are the same indeed, and the later is the a macro. Everytime before
>> we use the macro, call "PORT_ACCESS_FROM_ENV (env)"
>>    e.g.:
>>    somemethod(JNIEnv * env, ...){
>>     PORT_ACCESS_FROM_ENV (env);
>>     ...
>>     hymem_allocate_memory(sizeof(something));
>>     ...
>>    }
>>
>>    And they are defined in hyport.h. :)
>>     
>
> I think the second style is more readable, so would advocate using that.
>
> As you say, the readable macros are set up using the PORT_ACCESS_FROM_*
> directives, so that you can use them if you are passed different types.
>
> PORT_ACCESS_FROM_ENV(JNIEnv)      - you have a JNIEnv struct ptr
> PORT_ACCESS_FROM_JAVAVM(JavaVM)   - you have a JavaVM struct ptr
>   

> PORT_ACCESS_FROM_PORT(portlib)    - you have a portlib ptr
>   
So in the scenario of multiple HyPortLib instances, it can be used to 
specify which one to use?  Then how about document these directives and 
advocation on the port documentation instead of current ones?
> Regards,
> Tim
>
>   


-- 
Paulex Yang
China Software Development Lab
IBM


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org