harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang" <zhanghuang...@gmail.com>
Subject Re: [classlib][testing] question about org.apache.harmony.tests.java.nio.channels.SocketChannelTest
Date Fri, 30 Jun 2006 12:08:32 GMT
Hello Mikhail,

Totally agree with you. assertEquals doesn't make any sense here.

I will remove these useless assertEquals in NIO module tests.

Thanks!


On 6/30/06, Mikhail Loenko <mloenko@gmail.com> wrote:
>
> It is not clear why we have assertEquals in this type of constructions
>
>        try {
>            assertEquals(CAPACITY_NORMAL, this.channel1.read(buf));
>            fail("Should throw ClosedChannelException");
>        } catch (ClosedChannelException e) {
>            // correct
>        }
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Andrew Zhang
China Software Development Lab, IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message