harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: svn commit: r416344 - /incubator/harmony/enhanced/classlib/trunk/make/build-java.xml
Date Fri, 23 Jun 2006 00:21:39 GMT
not quite what I meant.

I want to be able to have a "build.properties" file in by /trunk
directory that is personal, not checked in, that lets me override stuff.

I was playing with it by adding a

  <property file="build.properties" />

before the <import> in build.xml, and the problem seems to be that our
invocation of build-java is "inheritall="false"" and then we read the
properties.xml file again in the build-java file, and it seems that a
<propertyset> in the <ant> in build.xml doesn't go through. The <import>
in build-java kills it?

One way I thought of is to do a

  <property file="build.properties" />

in build-java.xml as well right before the <import> and that works.

However, having to do this down the chain smells wrong, but I guess
we're doing it w/ the <import>.  I don't understand the idea behind it
(my ant sk1lz are rusty) so I'm hoping someone can shine some light here...

geir


Tim Ellison wrote:
> Sure -- done in r416469.
> 
> Regards,
> Tim
> 
> Geir Magnusson Jr wrote:
>> should we make this a property with a default so we can set it arbitrarily?
>>
>> Not asking you to do it, but just wondering how people feel about having
>> that sort of thing...
>>
>> geir
>>
>> tellison@apache.org wrote:
>>> Author: tellison
>>> Date: Thu Jun 22 05:14:48 2006
>>> New Revision: 416344
>>>
>>> URL: http://svn.apache.org/viewvc?rev=416344&view=rev
>>> Log:
>>> Reduce forked compilation VM memory requirements.
>>>
>>> Modified:
>>>     incubator/harmony/enhanced/classlib/trunk/make/build-java.xml
>>>
>>> Modified: incubator/harmony/enhanced/classlib/trunk/make/build-java.xml
>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/make/build-java.xml?rev=416344&r1=416343&r2=416344&view=diff
>>> ==============================================================================
>>> --- incubator/harmony/enhanced/classlib/trunk/make/build-java.xml (original)
>>> +++ incubator/harmony/enhanced/classlib/trunk/make/build-java.xml Thu Jun 22
05:14:48 2006
>>> @@ -80,7 +80,7 @@
>>>              description="Compile the source">
>>>          <mkdir dir="${build.output}" />
>>>  
>>> -        <javac fork="yes" memoryInitialSize="512M" memoryMaximumSize="600M"
>>> +        <javac fork="yes" memoryMaximumSize="384M"
>>>                 destdir="${build.output}"
>>>                 source="${hy.javac.source}" target="${hy.javac.target}"
>>>                 debug="${hy.javac.debug}">
>>>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message