harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <ge...@apache.org>
Subject Re: [jira] Commented: (HARMONY-634) Pack200 file with just resources
Date Wed, 21 Jun 2006 19:42:53 GMT


Alex Blewitt wrote:
> (Apologies for the large to: list; I'm still unsure how to reply to
> automatically generated e-mails)

Hit "reply" on you mailer?

The "reply-to" is set to the list.

> 
> It wouldn't hurt having the resources test as well as the hello world
> test. At some point, I should probably expand the test to check for
> the right filename etc. But we don't have to comment out the
> helloworld test if it's still working.
> 
> Alex.
> 
> On 21/06/06, Tim Ellison (JIRA) <jira@apache.org> wrote:
>>     [
>> http://issues.apache.org/jira/browse/HARMONY-634?page=comments#action_12417080
>> ]
>>
>> Tim Ellison commented on HARMONY-634:
>> -------------------------------------
>>
>> So given that the SegmentTest is still working ok with the
>> HelloWorld.pack, do you still want to apply this and switch to the
>> resources file?
>>
>>
>> > Pack200 file with just resources
>> > --------------------------------
>> >
>> >          Key: HARMONY-634
>> >          URL: http://issues.apache.org/jira/browse/HARMONY-634
>> >      Project: Harmony
>> >         Type: Bug
>>
>> >   Components: Classlib
>> >     Reporter: Alex Blewitt
>> >     Assignee: Tim Ellison
>> >     Priority: Trivial
>> >  Attachments: JustResources.pack, JustResources.patch
>> >
>> > This file is a pack200 Jar file that just contains resources, which
>> can be used to substitute the HelloWorld.pack that's used in the
>> SegmentTest test case.  I've commented out the one that will fail and
>> the JustResources.pack can be put in the same place as the
>> HelloWorld.pack one
>> > Index:
>> /Users/alex/Documents/HarmonyWorkspace/Pack200/src/test/java/org/apache/harmony/archive/tests/internal/pack200/SegmentTest.java
>>
>> > ===================================================================
>> > ---
>> /Users/alex/Documents/HarmonyWorkspace/Pack200/src/test/java/org/apache/harmony/archive/tests/internal/pack200/SegmentTest.java
 
>> (revision 415823)
>> > +++
>> /Users/alex/Documents/HarmonyWorkspace/Pack200/src/test/java/org/apache/harmony/archive/tests/internal/pack200/SegmentTest.java
 
>> (working copy)
>> > @@ -29,9 +29,17 @@
>> >        * @param args
>> >        * @throws Exception
>> >        */
>> > -     public void testHelloWorld() throws Exception {
>> > +//   public void testHelloWorld() throws Exception {
>> > +//           assertNotNull(Segment.parse(Segment.class
>> > +//                          
>> .getResourceAsStream("/org/apache/harmony/archive/tests/internal/pack200/HelloWorld.pack")));
>>
>> > +//   }
>> > +     /**
>> > +      * @param args
>> > +      * @throws Exception
>> > +      */
>> > +     public void testJustResources() throws Exception {
>> >               assertNotNull(Segment.parse(Segment.class
>> > -                            
>> .getResourceAsStream("/org/apache/harmony/archive/tests/internal/pack200/HelloWorld.pack")));
>>
>> > +                            
>> .getResourceAsStream("/org/apache/harmony/archive/tests/internal/pack200/JustResources.pack")));
>>
>> >       }
>> >
>> >  }
>>
>> -- 
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the administrators:
>>    http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see:
>>    http://www.atlassian.com/software/jira
>>
>>
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message