harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: [classlib] [testing] 37% of total test execution time is spent in a single test
Date Thu, 01 Jun 2006 15:18:40 GMT


Mikhail Loenko wrote:
> 2006/6/1, Geir Magnusson Jr <geir@pobox.com>:
>>
>> I don't quite grok what you mean - could you post what you are
>> suggesting in code here on -dev?
> 
> 
> Index: modules/luni/src/test/java/tests/api/java/net/Inet6AddressTest.java
> ===================================================================
> ---
> modules/luni/src/test/java/tests/api/java/net/Inet6AddressTest.java   
> (revision
> 410480)
> +++
> modules/luni/src/test/java/tests/api/java/net/Inet6AddressTest.java   
> (working
> copy)
> @@ -785,7 +785,7 @@
>                 "FFFF:FFFF:FFFF:FFFF:FFFF:FFFF:255.255.255.255",
>                 "0:0:0:0:0:0:0:0", "0:0:0:0:0:0:0.0.0.0" };
> 
> -        String invalidIPAddresses[] = { ":", "FFFF:FFFF", "1:1",
> "::1.2.3.444" };
> +        String invalidIPAddresses[] = { "FFFF:FFFF" };
> 
>         for (int i = 0; i < validIPAddresses.length; i++) {
> 
> 

Thx - why do you want to remove testing the others?  Because you believe
that it is in effect testing the resolver in the OS since each returns
the same answer,and thus it's testing the same thing over and over?

If so, I agree with you.

If not, I still don't grok the point :)

geir


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message