harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: [classlib] build.properties (was Re: svn commit: r416344 ...)
Date Sat, 24 Jun 2006 21:17:41 GMT
I think that command line properties are propagated across ant tasks.
Which is why things like:

  ant -Dtest.case=tests.api.java.lang.OutOfMemoryErrorTest \
      -Dbuild.module=luni test

work - i.e. test.case is passed down to modules/luni/build.xml

Regards,
 Mark.

On 24 June 2006 at 13:57, "Magnusson, Geir" <geir.magnusson@intel.com> wrote:
> That would work but doesn't solve cmd line prop propogation...
> 
> Still, better than nothing...
> 
> Why do we do it the way we do?
> 
> Geir (from fone...)
> 
>  -----Original Message-----
> From: 	Mark Hindess [mailto:mark.hindess@googlemail.com]
> Sent:	Saturday, June 24, 2006 01:49 PM Pacific Standard Time
> To:	harmony-dev@incubator.apache.org; geir@pobox.com
> Subject:	[classlib] build.properties (was Re: svn commit: r416344 ...)
> 
> 
> How about adding:
> 
>   <property file=3D"build.properties" />
> 
> to make/properties.xml?
> 
> Regards,
>  Mark.
> 
> On 22 June 2006 at 20:21, Geir Magnusson Jr <geir@pobox.com> wrote:
> > not quite what I meant.
> >=20
> > I want to be able to have a "build.properties" file in by /trunk
> > directory that is personal, not checked in, that lets me override =
> stuff.
> >=20
> > I was playing with it by adding a
> >=20
> >   <property file=3D"build.properties" />
> >=20
> > before the <import> in build.xml, and the problem seems to be that our
> > invocation of build-java is "inheritall=3D"false"" and then we read =
> the
> > properties.xml file again in the build-java file, and it seems that a
> > <propertyset> in the <ant> in build.xml doesn't go through. The =
> <import>
> > in build-java kills it?
> >=20
> > One way I thought of is to do a
> >=20
> >   <property file=3D"build.properties" />
> >=20
> > in build-java.xml as well right before the <import> and that works.
> >=20
> > However, having to do this down the chain smells wrong, but I guess
> > we're doing it w/ the <import>.  I don't understand the idea behind it
> > (my ant sk1lz are rusty) so I'm hoping someone can shine some light =
> here...
> >=20
> > geir
> >=20
> >=20
> > Tim Ellison wrote:
> > > Sure -- done in r416469.
> > >=20
> > > Regards,
> > > Tim
> > >=20
> > > Geir Magnusson Jr wrote:
> > >> should we make this a property with a default so we can set it =
> arbitrarily
> > ?
> > >>
> > >> Not asking you to do it, but just wondering how people feel about =
> having
> > >> that sort of thing...
> > >>
> > >> geir
> > >>
> > >> tellison@apache.org wrote:
> > >>> Author: tellison
> > >>> Date: Thu Jun 22 05:14:48 2006
> > >>> New Revision: 416344
> > >>>
> > >>> URL: http://svn.apache.org/viewvc?rev=3D416344&view=3Drev
> > >>> Log:
> > >>> Reduce forked compilation VM memory requirements.
> > >>>
> > >>> Modified:
> > >>>     incubator/harmony/enhanced/classlib/trunk/make/build-java.xml
> > >>>
> > >>> Modified: =
> incubator/harmony/enhanced/classlib/trunk/make/build-java.xml
> > >>> URL: =
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/tru
> > =
> nk/make/build-java.xml?rev=3D416344&r1=3D416343&r2=3D416344&view=3Ddiff
> > >>> =
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > =3D=3D=3D=3D=3D
> > >>> --- incubator/harmony/enhanced/classlib/trunk/make/build-java.xml =
> (origin
> > al)
> > >>> +++ incubator/harmony/enhanced/classlib/trunk/make/build-java.xml =
> Thu Jun
> >  22 05:14:48 2006
> > >>> @@ -80,7 +80,7 @@
> > >>>              description=3D"Compile the source">
> > >>>          <mkdir dir=3D"${build.output}" />
> > >>> =20
> > >>> -        <javac fork=3D"yes" memoryInitialSize=3D"512M" =
> memoryMaximumSize=3D"60
> > 0M"
> > >>> +        <javac fork=3D"yes" memoryMaximumSize=3D"384M"
> > >>>                 destdir=3D"${build.output}"
> > >>>                 source=3D"${hy.javac.source}" =
> target=3D"${hy.javac.target}"
> > >>>                 debug=3D"${hy.javac.debug}">
> > >>>
> > >>>
> > >>>
> > >>>
> > >> =
> ---------------------------------------------------------------------
> > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> To unsubscribe, e-mail: =
> harmony-dev-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: =
> harmony-dev-help@incubator.apache.org
> > >>
> > >>
> > >=20
> >=20
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message