harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: svn commit: r416477 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni: ./ src/main/java/java/net/ src/test/java/tests/api/java/net/
Date Sat, 24 Jun 2006 17:14:39 GMT

On 24 June 2006 at 20:10, Gregory Shimansky <gshimansky@gmail.com> wrote:
> On Saturday 24 June 2006 19:16 Geir Magnusson Jr wrote:
> > I seem to have found a doozy :)
> >
> > In hysock.c / getNextNetlinkMsg() there's an assumption that anything
> > the kernel will ever send in a netlink request is less than 1k, so when
> > processing the receive buffer, if there still is data in the buffer and
> > it's not a complete message, it's considered an error.
> >
> > This is clearly wrong, and provable by simply doubling the buffer size.
> > This is suboptimal, of course, because there is no guarantee that 2k
> > will be enough one all systems either.
> >
> > I'm going to stare at this and attempt to rewrite it this weekend if I
> > find some time.
> >
> > Man, this would be easier w/ a debugger :)
> 
> I have a question on this topic. Is there a reason why libhy*.so and other 
> classlib natives libraries are compiled without debug information? Addind -g 
> (-Zi on windows) to the options could really help sometimes.

No.  At least there isn't a good reason.  We should fix this.  I've
added it manually a couple of times which is always a sign that
something is needs fixing.

Regards,
 Mark.



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message