harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: svn commit: r415915 - /incubator/harmony/enhanced/classlib/trunk/depends/jars/
Date Thu, 22 Jun 2006 13:13:24 GMT

This change reminded me about something.  The big <javac> in
make/build-java.xml currently has:

  <classpath>
    <fileset dir="${depends.jars}">
      <include name="**/*.jar" />
    </fileset>
  </classpath>

which means that if you have old versions of dependencies in
depends/jars/*/*.jar then they will be picked up by the build.  I
actually saw a compiler error the other day because of this - building
with a version of ecj.

I assume Mikhail put these back because (like me) he likes to keep
the old versions around just in case he wants to test an old classlib
version - for instance doing a binary chop to find when a regression
occurred.

The fix for this would be to defined in depends.xml a reference property
that defined the fileset for the current versions of these dependencies.
I will take a look at this unless anyone objects.

Regards,
 Mark.

On 21 June 2006 at 5:24, mloenko@apache.org wrote:
> Author: mloenko
> Date: Tue Jun 20 22:24:58 2006
> New Revision: 415915
> 
> URL: http://svn.apache.org/viewvc?rev=415915&view=rev
> Log:
> add depends jars to svn:ignore
> 
> Modified:
>     incubator/harmony/enhanced/classlib/trunk/depends/jars/   (props changed)
> 
> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/jars/
> -----------------------------------------------------------------------------
> -
> --- svn:ignore (original)
> +++ svn:ignore Tue Jun 20 22:24:58 2006
> @@ -1,3 +1,4 @@
> +
>  bcprov-jdk14-133
>  ecj_3.2RC5
>  icu4j_3.4.4
> @@ -5,3 +6,7 @@
>  mx4j_3.0.1
>  xalan-j_2.7.0
>  xerces_2.8.0
> +bcprov-jdk14-132
> +junit_3.8.1
> +xalan-j_2.6.0
> +xerces_2.6.2
> 



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message